Problem/Motivation

  • Add the function to attach/detach OpenStack Snapshot in the SPA.

Issue fork cloud-3302260

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Masami created an issue. See original summary.

Masami opened merge request !1204

Masami’s picture

Masami CreditAttribution: Masami commented
Status: Active » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas as a volunteer and at DOCOMO Innovations, Inc. commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

@masami

Thank you for the patch. It looks good to me. I'll merge the patch to 4.x and 5.x, and close this issue as Fixed.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas as a volunteer and at DOCOMO Innovations, Inc. commented
Status: Reviewed & tested by the community » Needs work

@masami

I found the coding standard errors. Can you please fix them? Thanks

----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
 455 | ERROR | [x] Whitespace found at end of line
 473 | ERROR | [x] Whitespace found at end of line
Masami’s picture

Masami CreditAttribution: Masami commented
Status: Needs work » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas as a volunteer and at DOCOMO Innovations, Inc. commented
Status: Needs review » Reviewed & tested by the community

@masami

Thank you for the update. It looks good. I'll merge the patch to 4.x and 5.x, and close this issue as Fixed.

  • yas committed 8e706d5 on 5.x authored by Masami 
    Issue #3302260 by Masami, yas: Add the function to attach/detach...

  • yas committed 7289b94 on 4.x authored by Masami 
    Issue #3302260 by Masami, yas: Add the function to attach/detach...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas as a volunteer and at DOCOMO Innovations, Inc. commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.