Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
The "Advanced" pane doesn't align properly in views due to a regression within #3291100: Nested details element within content type's "manage display" UI changes width when opened
Comment | File | Size | Author |
---|---|---|---|
#13 | 3291100.gif | 454.27 KB | cindytwilliams |
#11 | after-opened.png | 961.66 KB | cindytwilliams |
#11 | after-closed.png | 886.17 KB | cindytwilliams |
#11 | before.png | 873.27 KB | cindytwilliams |
#7 | 3300941-10.0.x.patch | 2.58 KB | mherchel |
|
Issue fork drupal-3300941
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
cilefen CreditAttribution: cilefen commentedWhat about this is broken. Please update the title and issue summary with information.
Comment #3
Chi CreditAttribution: Chi for DXPR commentedComment #4
mherchelI can't reproduce this. I tested this in Chrome and the latest Drupal 10, and tried various different screen widths.
What else do I need to do to reproduce?
Comment #5
Chi CreditAttribution: Chi for DXPR commented@mherchel DId you use dev branch for testing? I think that caused by #3291100: Nested details element within content type's "manage display" UI changes width when opened.
Comment #6
mherchelYep! I see it! I was testing against a slightly older version of 10.0.x on Tugboat.
Updating summary. Note this happens in 9.4.x and later.
Comment #7
mherchelPatches attached.
Comment #9
Manibharathi E R CreditAttribution: Manibharathi E R at Srijan | A Material+ Company for Srijan | A Material+ Company commentedPatch #7 Applied and tested successfully on Drupal 9.5.x.
Comment #10
mherchel@Manibharathi E R
Thanks for your review! Note that your "after" screenshot has the offending
<details>
element cropped out.Comment #11
cindytwilliams CreditAttribution: cindytwilliams at Kanopi Studios commentedI tested this in Drupal 10 and it looks good to me in both Chrome and Firefox. The "Advanced" details section displays over to the right in a 3rd column on desktop (rather than being stuck at the bottom) and it stacks correctly on mobile. Screenshots attached.
Marking RTBC+1
Comment #12
Chi CreditAttribution: Chi for DXPR commentedWe probably should check if the fix made for #3291100: Nested details element within content type's "manage display" UI changes width when opened is still working.
Comment #13
cindytwilliams CreditAttribution: cindytwilliams at Kanopi Studios commentedI checked issue #3291100 as well and it is still working with this patch.
Comment #16
lauriiiCommitted cde980a and pushed to 10.1.x and cherry-picked to 10.0.x. Also committed to 9.5.x. Thanks!