The "Advanced" pane doesn't align properly in views due to a regression within #3291100: Nested details element within content type's "manage display" UI changes width when opened

Issue fork drupal-3300941

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Chi created an issue. See original summary.

cilefen’s picture

Status: Active » Postponed (maintainer needs more info)

What about this is broken. Please update the title and issue summary with information.

Chi’s picture

Title: Claro: broken views UI layout » Claro: views UI layout is not correct
Issue summary: View changes
Status: Postponed (maintainer needs more info) » Active
mherchel’s picture

I can't reproduce this. I tested this in Chrome and the latest Drupal 10, and tried various different screen widths.

What else do I need to do to reproduce?

Chi’s picture

mherchel’s picture

Title: Claro: views UI layout is not correct » Claro: Views UI layout is not aligned correctly
Version: 10.0.x-dev » 9.5.x-dev
Issue summary: View changes
FileSize
148.89 KB

Yep! I see it! I was testing against a slightly older version of 10.0.x on Tugboat.

Updating summary. Note this happens in 9.4.x and later.

mherchel’s picture

Status: Active » Needs review
FileSize
2.47 KB
2.58 KB

Patches attached.

Vighneshh made their first commit to this issue’s fork.

Manibharathi E R’s picture

FileSize
220.08 KB
181.5 KB

Patch #7 Applied and tested successfully on Drupal 9.5.x.

mherchel’s picture

@Manibharathi E R

Thanks for your review! Note that your "after" screenshot has the offending <details> element cropped out.

cindytwilliams’s picture

Status: Needs review » Reviewed & tested by the community
FileSize
873.27 KB
886.17 KB
961.66 KB

I tested this in Drupal 10 and it looks good to me in both Chrome and Firefox. The "Advanced" details section displays over to the right in a 3rd column on desktop (rather than being stuck at the bottom) and it stacks correctly on mobile. Screenshots attached.

Marking RTBC+1

Chi’s picture

cindytwilliams’s picture

FileSize
454.27 KB

I checked issue #3291100 as well and it is still working with this patch.

  • lauriii committed 1544b1d on 10.1.x
    Issue #3300941 by mherchel, cindytwilliams, Manibharathi E R, Chi: Claro...

  • lauriii committed a01e721 on 10.0.x
    Issue #3300941 by mherchel, cindytwilliams, Manibharathi E R, Chi: Claro...
lauriii’s picture

Status: Reviewed & tested by the community » Fixed

Committed cde980a and pushed to 10.1.x and cherry-picked to 10.0.x. Also committed to 9.5.x. Thanks!

  • lauriii committed 4d5900c on 9.5.x
    Issue #3300941 by mherchel, cindytwilliams, Manibharathi E R, Chi: Claro...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.