Vanilla JS rewrite of gin_ckeditor.js

Issue fork gin-3294545

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

saschaeggi created an issue. See original summary.

saschaeggi opened merge request !167

saschaeggi’s picture

saschaeggi
he/him
CreditAttribution: saschaeggi as a volunteer and commented
Status: Active » Needs review
darvanen’s picture

darvanen
he/him
Primary language English
Location Sydney, Australia
CreditAttribution: darvanen commented
Status: Needs review » Needs work

One major question in the MR to be discussed I think as changing it might make the rest of the review easier to do.

saschaeggi’s picture

saschaeggi
he/him
CreditAttribution: saschaeggi as a volunteer and commented
Status: Needs work » Needs review

Needs review.

There is a JS error as this has a depenency to accent.js which will be solved with the refactoring in #3294537: [JS Refactor] accent library and can safely be ignored in this case.

saschaeggi’s picture

saschaeggi
he/him
CreditAttribution: saschaeggi as a volunteer and commented

Made some small code improvements. Ready for review.

Note: that this has a dependency to the change in #3294537: [JS Refactor] accent library, so there will be a console error Uncaught TypeError: Drupal.ginAccent is undefined. To work around this issue, you can apply the following patch: https://git.drupalcode.org/project/gin/-/merge_requests/163.patch for testing purposes.

saschaeggi’s picture

saschaeggi
he/him
CreditAttribution: saschaeggi as a volunteer and commented
Issue tags: +Drupal10
saschaeggi’s picture

saschaeggi
he/him
CreditAttribution: saschaeggi as a volunteer and commented
Issue tags: +#Drupal10PortingDay, +Drupal 10 compatibility
saschaeggi’s picture

saschaeggi
he/him
CreditAttribution: saschaeggi as a volunteer and commented
Kristen Pol’s picture

Kristen Pol
she/her
Primary language English
Location Santa Cruz, CA, USA
CreditAttribution: Kristen Pol at Itty Bitty Byte for Salsa Digital commented
Issue tags: -#Drupal10PortingDay +Drupal 10 porting day

Fixing tag.

Kristen Pol’s picture

Kristen Pol
she/her
Primary language English
Location Santa Cruz, CA, USA
CreditAttribution: Kristen Pol at Itty Bitty Byte for Salsa Digital commented
Issue tags: -Drupal10 +Drupal 10

Whoops... 2 tags needed fixing... fixing the other one now.

saschaeggi’s picture

saschaeggi
he/him
CreditAttribution: saschaeggi as a volunteer and at GitLab commented

Ready for re-review 👀

saschaeggi’s picture

saschaeggi
he/him
CreditAttribution: saschaeggi as a volunteer and at GitLab commented
saschaeggi’s picture

saschaeggi
he/him
CreditAttribution: saschaeggi as a volunteer and at GitLab commented
saschaeggi’s picture

saschaeggi
he/him
CreditAttribution: saschaeggi as a volunteer and at GitLab commented

Still looking for a review here

saschaeggi’s picture

saschaeggi
he/him
CreditAttribution: saschaeggi as a volunteer and at GitLab commented
saschaeggi’s picture

saschaeggi
he/him
CreditAttribution: saschaeggi as a volunteer and at GitLab commented
Johan den Hollander’s picture

Johan den Hollander CreditAttribution: Johan den Hollander at Finalist commented
Status: Needs review » Reviewed & tested by the community

Hi I just tested with the latest diff as a path to gin 3.x-dev version on Drupal 10 with CKEditor 5.
It all seems to work really well, I did not notice anything broken.

Toggling code or wysiwyg, accent color, focus color, dark or light mode all applied as expected.
Therefore marking this as Reviewed.

  • saschaeggi committed ee11f62 on 8.x-3.x 
    Issue #3294545: [JS Refactor] gin_ckeditor.js
saschaeggi’s picture

saschaeggi
he/him
CreditAttribution: saschaeggi as a volunteer and at GitLab commented
Status: Reviewed & tested by the community » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.