Vanilla JS refactor of toolbar.js

Issue fork gin-3294543

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

saschaeggi created an issue. See original summary.

saschaeggi opened merge request !166

saschaeggi’s picture

saschaeggi
he/him
CreditAttribution: saschaeggi as a volunteer and commented
Status: Active » Needs review
darvanen’s picture

darvanen
he/him
Primary language English
Location Sydney, Australia
CreditAttribution: darvanen commented
Status: Needs review » Needs work

Just a couple of notes on this one.

saschaeggi’s picture

saschaeggi
he/him
CreditAttribution: saschaeggi as a volunteer and at GitLab commented
Status: Needs work » Needs review

Questions solved.
Moving this to needs review again :)

darvanen’s picture

darvanen
he/him
Primary language English
Location Sydney, Australia
CreditAttribution: darvanen commented
Status: Needs review » Needs work

One suggestion for your consideration

saschaeggi’s picture

saschaeggi
he/him
CreditAttribution: saschaeggi as a volunteer and at GitLab commented
Status: Needs work » Needs review

Back to review :)

saschaeggi’s picture

saschaeggi
he/him
CreditAttribution: saschaeggi as a volunteer and at GitLab commented

Added some changes, ready for review

saschaeggi’s picture

saschaeggi
he/him
CreditAttribution: saschaeggi as a volunteer and at GitLab commented
Issue tags: +Drupal10
saschaeggi’s picture

saschaeggi
he/him
CreditAttribution: saschaeggi as a volunteer and at GitLab commented
Issue tags: +#Drupal10PortingDay, +Drupal 10 compatibility
LittleCoding’s picture

LittleCoding
He/Him
Location Hamilton, ON
CreditAttribution: LittleCoding commented

There may also be a few more points that can use the `context` (https://git.drupalcode.org/project/gin/-/merge_requests/166#note_113942) in the function `Drupal.ginToolbar.init`.

saschaeggi’s picture

saschaeggi
he/him
CreditAttribution: saschaeggi as a volunteer and at GitLab commented

@LittleCoding great inputs, back to review 👏

LittleCoding’s picture

LittleCoding
He/Him
Location Hamilton, ON
CreditAttribution: LittleCoding commented

Looks good!

saschaeggi’s picture

saschaeggi
he/him
CreditAttribution: saschaeggi as a volunteer and at GitLab commented
Status: Needs review » Reviewed & tested by the community
Kristen Pol’s picture

Kristen Pol
she/her
Primary language English
Location Santa Cruz, CA, USA
CreditAttribution: Kristen Pol at Itty Bitty Byte for Salsa Digital commented
Issue tags: -#Drupal10PortingDay +Drupal 10 porting day

Fixing tag.

Kristen Pol’s picture

Kristen Pol
she/her
Primary language English
Location Santa Cruz, CA, USA
CreditAttribution: Kristen Pol at Itty Bitty Byte for Salsa Digital commented
Issue tags: -Drupal10 +Drupal 10

Whoops... 2 tags needed fixing... fixing the other one now.

saschaeggi’s picture

saschaeggi
he/him
CreditAttribution: saschaeggi as a volunteer and at GitLab commented
saschaeggi’s picture

saschaeggi
he/him
CreditAttribution: saschaeggi as a volunteer and at GitLab commented
saschaeggi’s picture

saschaeggi
he/him
CreditAttribution: saschaeggi as a volunteer and at GitLab commented

  • saschaeggi committed d601c0b on 8.x-3.x 
    Issue #3294543: [JS Refactor] toolbar library
saschaeggi’s picture

saschaeggi
he/him
CreditAttribution: saschaeggi as a volunteer and at GitLab commented
Status: Reviewed & tested by the community » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.