Vanilla JS rewrite of accent library.

CommentFileSizeAuthor
#22 node-edit-red-light-before.png1.54 MBbatigolix
#22 node-edit-red-light-after.png1.54 MBbatigolix
#22 node-edit-red-dark-before.png1.54 MBbatigolix
#22 node-edit-red-dark-after.png1.55 MBbatigolix
#22 node-edit-green-light-before.png1.54 MBbatigolix
#22 node-edit-green-light-after.png1.54 MBbatigolix
#22 node-edit-green-dark-before.png1.55 MBbatigolix
#22 node-edit-green-dark-after.png1.55 MBbatigolix
#22 admin-content-red-light-before.png1.41 MBbatigolix
#22 admin-content-red-light-after.png1.41 MBbatigolix
#22 admin-content-green-light-before.png1.41 MBbatigolix
#22 admin-content-green-light-after.png1.41 MBbatigolix

Issue fork gin-3294537

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

saschaeggi created an issue. See original summary.

saschaeggi opened merge request !163

saschaeggi’s picture

saschaeggi
he/him
CreditAttribution: saschaeggi as a volunteer and commented
Status: Active » Needs review
darvanen’s picture

darvanen
he/him
Primary language English
Location Sydney, Australia
CreditAttribution: darvanen commented
Status: Needs review » Needs work

A few questions here.

saschaeggi’s picture

saschaeggi
he/him
CreditAttribution: saschaeggi as a volunteer and at GitLab commented
Status: Needs work » Needs review

@darvanen thanks for testing/reviewing!

Ready for review again :)

saschaeggi’s picture

saschaeggi
he/him
CreditAttribution: saschaeggi as a volunteer and at GitLab commented

Note: There might be a JS error as gin_ckeditor.js uses a function from this JS which will be solved with the refactoring in #3294545: [JS Refactor] gin_ckeditor.js and can safely be ignored in this case.

darvanen’s picture

darvanen
he/him
Primary language English
Location Sydney, Australia
CreditAttribution: darvanen commented
Status: Needs review » Needs work

One response, one new question, there's a bit to unpack here I think - happy to chat on Slack if we can make timezones align.

saschaeggi’s picture

saschaeggi
he/him
CreditAttribution: saschaeggi as a volunteer and at GitLab commented
Status: Needs work » Needs review

Back to review :)

saschaeggi’s picture

saschaeggi
he/him
CreditAttribution: saschaeggi as a volunteer and at GitLab commented

Updated, needs review

saschaeggi’s picture

saschaeggi
he/him
CreditAttribution: saschaeggi as a volunteer and at GitLab commented

Note: to test this successfully on an entity containing an CKEditor instance, you'll need to apply the following patch https://git.drupalcode.org/project/gin/-/merge_requests/167.patch as #3294545: [JS Refactor] gin_ckeditor.js uses a function from the accent library.

saschaeggi’s picture

saschaeggi
he/him
CreditAttribution: saschaeggi as a volunteer and at GitLab commented
Issue tags: +Drupal10
saschaeggi’s picture

saschaeggi
he/him
CreditAttribution: saschaeggi as a volunteer and at GitLab commented
Issue tags: +#Drupal10PortingDay, +Drupal 10 compatibility
Kristen Pol’s picture

Kristen Pol
she/her
Primary language English
Location Santa Cruz, CA, USA
CreditAttribution: Kristen Pol at Itty Bitty Byte for Salsa Digital commented
Issue tags: -#Drupal10PortingDay +Drupal 10 porting day

Fixing tag.

Kristen Pol’s picture

Kristen Pol
she/her
Primary language English
Location Santa Cruz, CA, USA
CreditAttribution: Kristen Pol at Itty Bitty Byte for Salsa Digital commented
Issue tags: -Drupal10 +Drupal 10

Whoops... 2 tags needed fixing... fixing the other one now.

saschaeggi’s picture

saschaeggi
he/him
CreditAttribution: saschaeggi as a volunteer and at GitLab commented

Back to review 👏

saschaeggi’s picture

saschaeggi
he/him
CreditAttribution: saschaeggi as a volunteer and at GitLab commented
saschaeggi’s picture

saschaeggi
he/him
CreditAttribution: saschaeggi as a volunteer and at GitLab commented
saschaeggi’s picture

saschaeggi
he/him
CreditAttribution: saschaeggi as a volunteer and at GitLab commented
saschaeggi’s picture

saschaeggi
he/him
CreditAttribution: saschaeggi as a volunteer and at GitLab commented
saschaeggi’s picture

saschaeggi
he/him
CreditAttribution: saschaeggi as a volunteer and at GitLab commented
batigolix’s picture

batigolix
Primary language Dutch
Location Utrecht
CreditAttribution: batigolix at Finalist commented
Assigned: Unassigned » batigolix
batigolix’s picture

batigolix
Primary language Dutch
Location Utrecht
CreditAttribution: batigolix at Finalist commented
Assigned: batigolix » Unassigned
Status: Needs review » Reviewed & tested by the community
FileSize
admin-content-green-light-after.png1.41 MB
admin-content-green-light-before.png1.41 MB
admin-content-red-light-after.png1.41 MB
admin-content-red-light-before.png1.41 MB
node-edit-green-dark-after.png1.55 MB
node-edit-green-dark-before.png1.55 MB
node-edit-green-light-after.png1.54 MB
node-edit-green-light-before.png1.54 MB
node-edit-red-dark-after.png1.55 MB
node-edit-red-dark-before.png1.54 MB
node-edit-red-light-after.png1.54 MB
node-edit-red-light-before.png1.54 MB

I applied the changes, without errors.

I compared 6 situations:
- node edit form, green accent, dark mode
- node edit form, red accent, dark mode
- node edit form, green accent, light mode
- node edit form, red accent, light mode
- admin content view, green accent, light mode
- admin content view, red accent, light mode

I did not detect any issues.

  • saschaeggi committed f5de96b on 8.x-3.x 
    Issue #3294537: [JS Refactor] accent library
saschaeggi’s picture

saschaeggi
he/him
CreditAttribution: saschaeggi as a volunteer and at GitLab commented
Status: Reviewed & tested by the community » Fixed

Thanks y'all!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.