[JS Refactor] media library

Had a look through the changes, on the whole they look good but the views.forEach(...) call makes some things obvious that really weren't in the JQuery version. Most of my comments revolve around the implied support for multiple views on a page.

Couple of detailed answers/expansions, please excuse if tone reads as anything other than helpful, trying to be as explicit as I can :)

Fixing tag.

Whoops... 2 tags needed fixing... fixing the other one now.

It seems to be the case that these `override` JS files are written directly in JS rather than in ES6 and built out to a JS. It would be better to have these files built by a set of ES6 as is the case in core themes like Classy.

Directly jumping to using ES6 would have the theme with a different browser support level vs D9 core. In terms of core this direct use of ES6 is not planned until D10. I thought the goal if this current round of updates was to remove jQuery dependencies while keep the same level of browser support as the active Drupal cores, is this not the case?

Well then, this section would be ahead of things then. Looks and works great from my testing. Maybe just some developer commenting of the JS.

I did some functional testing today for this MR. I noticed the following JS Error when I click to "Add media" on a Media Field and then select or unselect an existing media item:

Uncaught TypeError: Cannot read properties of null (reading 'checked')
    at HTMLDivElement.<anonymous> (<anonymous>:158:27)

The error gets triggered in media_library.view.js:53 from this change https://git.drupalcode.org/project/gin/-/merge_requests/162/diffs#fd46d7...

It seems to be an issue with the selectAll selector:

The media item was added successfully to the media field regardless of the JS error. Otherwise, I could not find any errors.

@saschaeggi thanks for the fix, I couldn't reproduce the error anymore.

I did some more testing and noticed this two JS Errors:

There seems to be an issue with the bulkOperations Selector when I try to select a media item in the media library:
media_library.view.js:67 Uncaught TypeError: Cannot read properties of null (reading 'classList')

I get a second error when I have multiple media items in the media library and select them all. I get the following error selecting the last item:
media_library.view.js:57 Uncaught TypeError: Cannot set properties of null (setting 'checked')

Looks good to me now, I couldn't find any more bugs. I am changing the status to reviewed 👍

Just doing a re-read of the Drupal JS Coding standards and it looks like the `@file` comment to start a JS file is required -- https://www.drupal.org/docs/develop/standards/javascript/javascript-codi...

👍