• Add --api-endpoint-base option to make it easier to run the script.
  • Make the script exit with an error message if --project-id is not passed.
  • Improve the message displayed when the --dry-run option is passed.

Issue fork cloud-3292812

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

onotm created an issue. See original summary.

onotm’s picture

onotm CreditAttribution: onotm commented
Issue summary: View changes

onotm opened merge request !1131

onotm’s picture

onotm CreditAttribution: onotm commented
Status: Active » Needs review

@kumikoono @yas I've updated the cleanup script for OpenStack resources. Could you review it?

yas made their first commit to this issue’s fork.

kumikoono’s picture

kumikoono CreditAttribution: kumikoono at DOCOMO Innovations, Inc. commented
Status: Needs review » Reviewed & tested by the community

Thanks for the update. This looks good to me.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
Issue summary: View changes
Status: Reviewed & tested by the community » Needs work

@kumikoono

Thank you for your review.

@onotm

I found the script uses a jq command; so could you please add some code to install a jq command if a Linux system doesn't have it? The code can be expected as something like:

https://git.drupalcode.org/project/cloud/-/blob/5.x/tests/src/Behat/scri...

onotm’s picture

onotm CreditAttribution: onotm commented
Status: Needs work » Needs review

@yas Thank you for your comment. I've updated the script. Could you see this commit?

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
Title: Improve the cleanup script for OpenStack resources » Refactor the cleanup script for OpenStack resources
Status: Needs review » Reviewed & tested by the community

@onotm

Thank you for the update. It looks good to me now. I'll merge the patch to 4.x and 5.x, and close this issue as Fixed.

  • yas committed 69d9ab0 on 5.x authored by onotm 
    Issue #3292812 by onotm, yas, kumikoono: Refactor the cleanup script for...

  • yas committed 56a259d on 4.x authored by onotm 
    Issue #3292812 by onotm, yas, kumikoono: Refactor the cleanup script for...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.