I've installed a fresh version of Drupal 9.4.1 with ECA RC1 and bpmn_io RC1 (btw RC1 isn't listed in the dropdown list of available versions for this issue yet -> selected beta12 but the issue is about RC1 and I've tested only with that version). I've used Claro as the admin theme. I've used nginx/1.22.0, PHP 8.1.6 and MariaDB 10.5.16 with DDEV. I've installed all modules in the ECA section on the extend page except ECA Entity Share Client and Entity Share Server. On admin/config/workflow/eca I've created a new model. I ran into the following issue (tested with Safari 13.1.2 and Firefox 101.0.1 with identical results):

eca new model window with a deprecation warning window underneath

I am unable to copy and paste the output directly from the error message on the new model page. I am unable to select the text. The two error messages shown look the same. Therefor I've only copied the error once from the recent log messages page:

Location: https://eca.ddev.site/admin/config/workflow/eca/add/bpmn-io
Referrer: 
Message:
Deprecated function: Calling static trait method Drupal\eca\Service\ServiceTrait::convertKeyToLabel is deprecated, it should only be called on a class using the trait in Drupal\eca_modeller_bpmn\ModellerBpmnBase->prepareConfigFields() (line 736 of /var/www/html/web/modules/contrib/eca/modules/modeller_bpmn/src/ModellerBpmnBase.php)

#0 /var/www/html/web/core/includes/bootstrap.inc(347): _drupal_error_handler_real(8192, 'Calling static ...', '/var/www/html/w...', 736)
#1 /var/www/html/web/modules/contrib/eca/modules/modeller_bpmn/src/ModellerBpmnBase.php(736): _drupal_error_handler(8192, 'Calling static ...', '/var/www/html/w...', 736)
#2 /var/www/html/web/modules/contrib/eca/modules/modeller_bpmn/src/ModellerBpmnBase.php(588): Drupal\eca_modeller_bpmn\ModellerBpmnBase->prepareConfigFields(Array)
#3 /var/www/html/web/modules/contrib/eca/modules/modeller_bpmn/src/ModellerBpmnBase.php(538): Drupal\eca_modeller_bpmn\ModellerBpmnBase->properties(Object(Drupal\eca_config\Plugin\ECA\Event\ConfigEvent), 'event', 'bpmn:Event', Array)
#4 /var/www/html/web/modules/contrib/bpmn_io/src/Plugin/ECA/Modeller/BpmnIo.php(74): Drupal\eca_modeller_bpmn\ModellerBpmnBase->getTemplates()
#5 /var/www/html/web/modules/contrib/bpmn_io/src/Controller/BpmnIo.php(61): Drupal\bpmn_io\Plugin\ECA\Modeller\BpmnIo->edit()
#6 [internal function]: Drupal\bpmn_io\Controller\BpmnIo->add()
#7 /var/www/html/web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(123): call_user_func_array(Array, Array)
#8 /var/www/html/web/core/lib/Drupal/Core/Render/Renderer.php(564): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}()
#9 /var/www/html/web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(124): Drupal\Core\Render\Renderer->executeInRenderContext(Object(Drupal\Core\Render\RenderContext), Object(Closure))
#10 /var/www/html/web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(97): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array)
#11 /var/www/html/vendor/symfony/http-kernel/HttpKernel.php(158): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}()
#12 /var/www/html/vendor/symfony/http-kernel/HttpKernel.php(80): Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object(Symfony\Component\HttpFoundation\Request), 1)
#13 /var/www/html/web/core/lib/Drupal/Core/StackMiddleware/Session.php(58): Symfony\Component\HttpKernel\HttpKernel->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#14 /var/www/html/web/core/lib/Drupal/Core/StackMiddleware/KernelPreHandle.php(48): Drupal\Core\StackMiddleware\Session->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#15 /var/www/html/web/core/modules/page_cache/src/StackMiddleware/PageCache.php(106): Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#16 /var/www/html/web/core/modules/page_cache/src/StackMiddleware/PageCache.php(85): Drupal\page_cache\StackMiddleware\PageCache->pass(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#17 /var/www/html/web/core/lib/Drupal/Core/StackMiddleware/ReverseProxyMiddleware.php(48): Drupal\page_cache\StackMiddleware\PageCache->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#18 /var/www/html/web/core/lib/Drupal/Core/StackMiddleware/NegotiationMiddleware.php(51): Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#19 /var/www/html/vendor/stack/builder/src/Stack/StackedHttpKernel.php(23): Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#20 /var/www/html/web/core/lib/Drupal/Core/DrupalKernel.php(709): Stack\StackedHttpKernel->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#21 /var/www/html/web/index.php(19): Drupal\Core\DrupalKernel->handle(Object(Symfony\Component\HttpFoundation\Request))
#22 {main}

I've tested the same steps with PHP 8.0 and the deprecation error hasn't shown there. If I switch back to PHP 8.1.6 the error is back. And in regards the display of the error message I've linked two related issue. https://www.drupal.org/project/bpmn_io/issues/3279961 seems at least in the context of this issue still be problematic.

CommentFileSizeAuthor
deprecated.png579.68 KBrkoller

Issue fork eca-3292362

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

rkoller created an issue. See original summary.

mxh’s picture

Version: 1.0.0-beta12 » 1.0.x-dev

I suppose that this is also in 1.0.0-rc1 then. Strange that we cannot select the RC1 from the version select list (yet?).

mxh’s picture

Priority: Normal » Critical

Confirmed the bug, this is critical as it's in RC1 and makes ECA UI currently unusable when using PHP 8.1.

mxh’s picture

Status: Active » Needs review

Once this one is fixed, we need a hotfix release.

rkoller’s picture

Status: Needs review » Reviewed & tested by the community

I suppose that this is also in 1.0.0-rc1 then. Strange that we cannot select the RC1 from the version select list (yet?).

No as mentioned in the bolded passage in the issue summary I've only tested with RC1. I have NOT installed and tested with beta12. I was just hesitant to label the issue with dev since dev "might" be ahead of RC1 already. And I've quickly looked yesterday night or better this morning if there is somewhere a way to trigger or add RC1 to the list but no luck in the d.o ui nor in my brief search on the docs pages. :(

Thanks for the quick patch. I've applied the patch after waking up right away. The deprecation error is gone now. There is also no new entry in the logs. I've then also quickly tested to save the new model. Now the admin notice is show above the BPMN ui as expected. So I suppose the showing of the error underneath was due to surrounding conditions - a chain of unfortunate events maybe. I'll keep an eye on it when testing further over the weekend. But I'll set the issue to RTBC.

jurgenhaas made their first commit to this issue’s fork.

  • mxh committed 7b99d86 on 1.0.x
    Issue #3292362 by mxh, rkoller: Getting deprecated function: calling...
jurgenhaas’s picture

Status: Reviewed & tested by the community » Fixed

Thanks for reporting and fixing this, RC2 is onits way.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.