• Add a BDD test suite for a security group

Issue fork cloud-3292142

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

shota niioka created an issue. See original summary.

shota niioka opened merge request !1112

shota niioka’s picture

shota niioka CreditAttribution: shota niioka commented
Status: Active » Needs review

Could you review this patch?
Thanks.

kumikoono’s picture

kumikoono CreditAttribution: kumikoono at DOCOMO Innovations, Inc. commented
Status: Needs review » Needs work

Thanks for your work. I tested and encountered the error. Can you check my comment?

shota niioka’s picture

shota niioka CreditAttribution: shota niioka commented

Could you review this patch ?
Thanks.

shota niioka’s picture

shota niioka CreditAttribution: shota niioka commented
Status: Needs work » Needs review
kumikoono’s picture

kumikoono CreditAttribution: kumikoono at DOCOMO Innovations, Inc. commented
Status: Needs review » Needs work

Mostly the patch looks good. Can you change where you add @wip tags?

yas made their first commit to this issue’s fork.

shota niioka’s picture

shota niioka CreditAttribution: shota niioka commented
Status: Needs work » Needs review

I fixed tags ,
Could you review this patch ?
Thanks.

kumikoono’s picture

kumikoono CreditAttribution: kumikoono at DOCOMO Innovations, Inc. commented
Status: Needs review » Reviewed & tested by the community

Thanks for the update. This looks good to me.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
Issue summary: View changes

@kumikoono

Thank you for your review.

@shota-niioka

I'll merge the patch to 4.x and 5.x, and close this issue as Fixed.

  • yas committed 496f543 on 5.x authored by shota niioka 
    Issue #3292142 by shota niioka, kumikoono, yas: Add a BDD test suite for...

  • yas committed ae18235 on 4.x authored by shota niioka 
    Issue #3292142 by shota niioka, yas, kumikoono: Add a BDD test suite for...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
Status: Reviewed & tested by the community » Needs work

@shota-niioka

Could you please create a hotfix to remove the trailing whitespaces at the line: https://git.drupalcode.org/project/cloud/-/blob/5.x/modules/cloud_servic...?

Thanks!

shota niioka opened merge request !1135

shota niioka’s picture

shota niioka CreditAttribution: shota niioka commented

I fixed as a hot-fix ,
Could you review this patch ?
Thanks.

shota niioka’s picture

shota niioka CreditAttribution: shota niioka commented
Status: Needs work » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
Status: Needs review » Needs work

@shota-niioka

Thank you for the update. It looks good, but I found a typo. Could you please fix it? Thanks

shota niioka’s picture

shota niioka CreditAttribution: shota niioka commented
Status: Needs work » Needs review

I fixed and rebased this patch ,
Could you review this patch ?
Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
Status: Needs review » Reviewed & tested by the community

@shota-niioka

Thank you for the fix. It looks good. I'll merge the patch to 4.x and 5.x, and close this issue as Fixed.

  • yas committed 91c6a59 on 5.x authored by shota niioka 
    Issue #3292142 by shota niioka, yas: Hotfix - Add a BDD test suite for...

  • yas committed fbd864e on 4.x authored by shota niioka 
    Issue #3292142 by shota niioka, yas: Hotfix - Add a BDD test suite for...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.