• Add a BDD test suite for VMs (Suspend and Reboot)

Issue fork cloud-3292111

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

makoto suzuki created an issue. See original summary.

makoto suzuki opened merge request !1111

yas made their first commit to this issue’s fork.

kumikoono’s picture

kumikoono CreditAttribution: kumikoono at DOCOMO Innovations, Inc. commented
Status: Needs work » Reviewed & tested by the community

This patch includes the changed for other issues.
I reviewed part for this issue only. The part looks good to me.

kumikoono’s picture

kumikoono CreditAttribution: kumikoono at DOCOMO Innovations, Inc. commented
Status: Reviewed & tested by the community » Needs work

Can you exclude the changes. for other issues?

makoto suzuki’s picture

makoto suzuki CreditAttribution: makoto suzuki commented
Status: Needs work » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas as a volunteer and at DOCOMO Innovations, Inc. commented
Title: Add a BDD test suite for VMs (Suspend and Reboot) » Add a BDD test suite for VMware VMs (Suspend and Reboot)
kumikoono’s picture

kumikoono CreditAttribution: kumikoono at DOCOMO Innovations, Inc. commented
Status: Needs review » Needs work

Thanks for providing this patch. Can you check my comment?

makoto suzuki’s picture

makoto suzuki CreditAttribution: makoto suzuki commented
Status: Needs work » Needs review

I implemented a local rebase.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas as a volunteer and at DOCOMO Innovations, Inc. commented
Issue summary: View changes
Status: Needs review » Needs work

@makoto-suzuki

Thank you for the update. I posted my comment for the feature description. Could you please check it? Thanks

makoto suzuki’s picture

makoto suzuki CreditAttribution: makoto suzuki commented
Status: Needs work » Needs review

I rebased locally and resolved the conflict.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas as a volunteer and at DOCOMO Innovations, Inc. commented
Status: Needs review » Needs work

@makoto-suzuki

Thank you for the update. Could you please double-check my comments?

My concert is: 1) the indent and 2) vm_host vs host_name.

Thanks

makoto suzuki’s picture

makoto suzuki CreditAttribution: makoto suzuki commented
Status: Needs work » Needs review

I implemented a local rebase.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas as a volunteer and at DOCOMO Innovations, Inc. commented
Status: Needs review » Reviewed & tested by the community

@makoto-suzuki

Thank you for rebasing the patch. It looks good. I'll merge the patch to 4.x and 5.x, and close this issue as Fixed.

  • yas committed a679a13 on 5.x authored by makoto suzuki 
    Issue #3292111 by makoto suzuki, yas, kumikoono: Add a BDD test suite...

  • yas committed 0f69209 on 4.x authored by makoto suzuki 
    Issue #3292111 by makoto suzuki, yas, kumikoono: Add a BDD test suite...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas as a volunteer and at DOCOMO Innovations, Inc. commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.