Problem/Motivation
Hello project maintainers,
This is an automated issue to help make this module compatible with Drupal 10.
To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects
Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.
The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.
Proposed resolution
You have a few options for how to use this issue:
- Accept automated patches until this issue is closed
If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.
As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.
Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.
- Leave open but stop new automated patches.
If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.
- Close it and don't use it
If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.
If the issue is reopened, then new automated patches will be posted.
If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.
Remaining tasks
Using the patches
- Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
- Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
- Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.
Providing feedback
If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.
| Comment | File | Size | Author |
|---|---|---|---|
| #12 | password_eye-3289016-11.patch | 1.1 KB | sneha_surve |
| #11 | Screenshot 2023-09-27 at 5.25.32 PM.png | 102.4 KB | sneha_surve |
| #11 | Screenshot 2023-09-27 at 5.25.32 PM.png | 102.4 KB | sneha_surve |
| #8 | Screenshot 2023-03-02 at 1.52.54 PM.png | 231.13 KB | arunkumark |
| #7 | password_eye.2.0.x-dev.rector.patch | 751 bytes | project update bot |
Issue fork password_eye-3289016
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
project update bot commentedThis is an automated patch generated by Drupal Rector. Please see the issue summary for more details.
It is important that any automated tests available are run with this patch and that you manually test this patch.
Drupal 10 Compatibility
According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.
Currently Drupal Rector, version 0.12.0, cannot fix all Drupal 10 compatibility problems.
This patch does not update the
info.ymlfile for Drupal 10 compatibility.Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.
Debug info
This patch was created using these packages:
Comment #3
project update bot commentedThis is an automated patch generated by Drupal Rector. Please see the issue summary for more details.
It is important that any automated tests available are run with this patch and that you manually test this patch.
Drupal 10 Compatibility
According to the Upgrade Status module this patch makes this module compatible with Drupal 10! 🎉
This patch updates the
info.ymlfile for Drupal 10 compatibility.Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.
Debug info
This patch was created using these packages:
Comment #4
akshaydalvi212 commentedHello,
Thanks for the auto-bot patch.
I will review the patch.
Comment #5
akshaydalvi212 commentedHello,
Before applying the patch, getting the following errors for drupal 10 compatibilities:

After applying the patch, all the above errors are eliminated and the module is compatible with drupal 10

according to the result of the scan by the upgrade-status module.
The Module gets installed on drupal 10 smoothly and works effectively as follows

With Password eye icon and also in working condition.


During the Drupal 10 Readiness Initiative meeting, it was discussed whether or not to mark bot issues "RTBC" when humans have successfully tested them and the decision was "yes". So, moving this from "Needs Review" to "RTBC" based on the successful testing above. If the maintainer prefers to move this back to "Active" or "Needs review", please just add a note explaining why it is shifted back to "Active" or "Needs review" state.
Thanks and regards.
Comment #6
project update bot commentedUpdating bot issue summary.See #3313904: Update project bot templates for RTBC status support and human interaction tips
Comment #7
project update bot commentedThis is an automated patch generated by Drupal Rector. Please see the issue summary for more details.
It is important that any automated tests available are run with this patch and that you manually test this patch.
Drupal 10 Compatibility
According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.
Currently Drupal Rector, version 0.13.1, cannot fix all Drupal 10 compatibility problems.
Therefore this patch does not update the
info.ymlfile for Drupal 10 compatibility.Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.
Debug info
This patch was created using these packages:
Comment #8
arunkumarkThe patch was applied cleanly and the module worked as expected.
So, moving to RTBC.
Comment #10
arunkumarkCreated MR for easy code publishing for the maintainer.
https://git.drupalcode.org/issue/password_eye-3289016/-/compare/2.0.x......
Comment #11
sneha_surve commentedTested patch with Drupal 10.
Patch is applying cleanly for 2.0.0
Comment #12
sneha_surve commentedComment #13
slipstreamer commentedHi, Is there anything stopping this patch being rolled into Password Eye 2.1?, also that release is missing the Drupal 10 definition that would define it as a proper Drupal 10 module which is included in this patch to be placed in the modules info file.
Comment #14
dineshkumarbollu commentedHi
I tested the MR!3 on my D10 site password eye is working fine. Drupal 10 release needed for my prod sites, And also i am interested in new maintainership.
Thanks
Comment #17
yuseferi commentedGreat! I will create a Release for it. Thank you :)
Comment #20
yuseferi commentedReleased https://www.drupal.org/project/password_eye
Comment #21
yuseferi commented