Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects

Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.

The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.

CommentFileSizeAuthor
#10 upgrade status.png100.54 KBameymudras
#10 panels.png209.03 KBameymudras
#10 module install.png147.52 KBameymudras
#7 interdiff.txt4.19 KBLal_
#7 3288960-7.patch23.78 KBLal_
#5 panels.4.x-dev.rector.patch18.65 KBProject Update Bot
#5 interdiff-last-bot.6663669.txt2.32 KBProject Update Bot
#4 panels.4.x-dev.rector.patch17.08 KBProject Update Bot
#4 interdiff-last-bot.6644518.txt15.59 KBProject Update Bot
#2 panels.4.x-dev.rector.patch7.39 KBProject Update Bot

Issue fork panels-3288960

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Project Update Bot created an issue. See original summary.

Project Update Bot’s picture

Project Update Bot CreditAttribution: Project Update Bot commented
Status: Active » Needs review
FileSize
panels.4.x-dev.rector.patch7.39 KB

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.

Currently Drupal Rector, version 0.12.0, cannot fix all Drupal 10 compatibility problems.

This patch does not update the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #127

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.9
  2. palantirnet/drupal-rector: 0.12.0

Status: Needs review » Needs work

The last submitted patch, 2: panels.4.x-dev.rector.patch, failed testing. View results

Project Update Bot’s picture

Project Update Bot CreditAttribution: Project Update Bot commented
Status: Needs work » Needs review
FileSize
interdiff-last-bot.6644518.txt15.59 KB
panels.4.x-dev.rector.patch17.08 KB

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.

Currently Drupal Rector, version 0.13.0, cannot fix all Drupal 10 compatibility problems.

This patch does not update the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #139

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.24
  2. palantirnet/drupal-rector: 0.13.0
Project Update Bot’s picture

Project Update Bot CreditAttribution: Project Update Bot commented
FileSize
interdiff-last-bot.6663669.txt2.32 KB
panels.4.x-dev.rector.patch18.65 KB

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.

Currently Drupal Rector, version 0.13.1, cannot fix all Drupal 10 compatibility problems.

This patch does not update the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #145

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.25
  2. palantirnet/drupal-rector: 0.13.1
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Issue summary: View changes

Could we please have this committed? It's a dependency on making Metatag work on D10 (the dependency will be removed in Metatag 2.0.0). Thank you.

Lal_’s picture

Lal_
He\Him
CreditAttribution: Lal_ as a volunteer and at QED42 commented
FileSize
3288960-7.patch23.78 KB
interdiff.txt4.19 KB
joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad commented

@DamienMcKenna, I agree that this issue should move forward. I think this project needs some new maintainers and their project page needs to be updated. It says that they recommend layout builder instead however layout builder doesn't work correctly with Bootstrap 3.x whereas panels does work with bootstrap 3.x.

There's 135,000 installs of panels and I think it would be a mistake to abandon it as it still works very well. I've spent a lot of time trying to fix layout builder so that it works with bootstrap 3.x but it's just not going to and I have external hard dependency requirements we cannot abandon Bootstrap 3.x due to organizational dependencies. It's actually quite a big deal.

attilatilman made their first commit to this issue’s fork.

ameymudras’s picture

ameymudras CreditAttribution: ameymudras at Salsa Digital commented
Status: Needs review » Needs work
FileSize
module install.png147.52 KB
panels.png209.03 KB
upgrade status.png100.54 KB

Tested the module on 10.0.x and php 8.1

- Patch 7 applies cleanly
- There is a dependency on jquer_ui, jquery_ui_draggable and jquery_ui_droppable modules
- Tested with page manager module, was able to install the module without any issue
- Was able to create a new page and variant and the page renders correctly
- No warnings / errors in the logs too
- Upgrade status shows "Class Drupal\panels_ipe\Form\PanelsIPEBlockContentForm extends @internal class Drupal\block_content\BlockContentForm." error

Only suggestion is, in /panels_ipe/src/Controller/PanelsIPEPageController.php we are using \Drupal call which can be avoided and use dependency injection instead.

foreach ($layouts as $id => $layout) {
-      $icon = $layout->getIconPath() ?: drupal_get_path('module', 'panels') . '/layouts/no-layout-preview.png';
+      $icon = $layout->getIconPath() ?: \Drupal::service('extension.list.module')->getPath('panels') . '/layouts/no-layout-preview.png';
Project Update Bot’s picture

Project Update Bot CreditAttribution: Project Update Bot commented
Issue summary: View changes

Updating bot issue summary.See #3313904: Update project bot templates for RTBC status support and human interaction tips

Kristen Pol’s picture

Kristen Pol
she/her
Primary language English
Location Santa Cruz, CA, USA
CreditAttribution: Kristen Pol at Itty Bitty Byte for Salsa Digital commented
Issue summary: View changes
Status: Needs work » Reviewed & tested by the community

@ameymudras Thanks for testing the functionality on Drupal 10 and reviewing the code. Since your code improvement isn't required to be Drupal 10 compatible, I'm going to mark this RTBC based on your testing+review.

mmjvb’s picture

mmjvb CreditAttribution: mmjvb as a volunteer commented

@maintainer Consider fixing this from #10 upon commit:

- Upgrade status shows "Class Drupal\panels_ipe\Form\PanelsIPEBlockContentForm extends @internal class Drupal\block_content\BlockContentForm." error

phenaproxima made their first commit to this issue’s fork.

phenaproxima opened merge request !6

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Status: Reviewed & tested by the community » Needs work

Added few comments to MR, mostly a lot of `info.yml` changes

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Status: Needs work » Needs review
nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ at Acquia commented

All good for me on the JS/jQuery UI front.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Status: Needs review » Reviewed & tested by the community

Thank you, I find it ready to go!

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented

  • phenaproxima committed 5ef3b13 on 8.x-4.x 
    Issue #3288960 by phenaproxima, Lal_, ameymudras, andypost: Automated...
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Status: Reviewed & tested by the community » Fixed

Merged with relief into 8.x-4.x. Thanks to all who helped move this along!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

joelpittet credited paulocs.

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet at The University of British Columbia commented

joelpittet credited angel.h.

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet at The University of British Columbia commented