Problem/Motivation

We can have a little bit less complexity in \Drupal\Core\Site\Settings::initialize()

Proposed resolution

Less ifs

Remaining tasks

User interface changes

None

API changes

None

Data model changes

Nonr

Release notes snippet

N/a

CommentFileSizeAuthor
#2 3284970-2.patch1.74 KBalexpott
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Status: Active » Needs review
FileSize
3284970-2.patch1.74 KB

This is a quick follow-up to #3284502: [regression] Drupal 9.4 breaks BC via incorrect autoloading of \Drupal\Driver\* overrides of core db drivers

Status: Needs review » Needs work

The last submitted patch, 2: 3284970-2.patch, failed testing. View results

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Status: Needs work » Needs review
mondrake’s picture

mondrake
Location 🇮🇹
CreditAttribution: mondrake as a volunteer commented
Status: Needs review » Reviewed & tested by the community

Looks sensible.

  • catch committed 3231fae on 9.4.x 
    Issue #3284970 by alexpott: Reduce complexity in \Drupal\Core\Site\...
  • catch committed c1a3078 on 9.5.x
    Issue #3284970 by alexpott: Reduce complexity in \Drupal\Core\Site\...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 10.0.x, cherry-picked to 9.5.x and 9.4.x, thanks!

  • catch committed 2b2ab4b on 10.0.x 
    Issue #3284970 by alexpott: Reduce complexity in \Drupal\Core\Site\...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.