Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
The current doc says:
"Collects JOIN and WHERE statements via hook_sql"
It seems it should say:
"Collects JOIN and WHERE statements via hook_db_rewrite_sql" instead, and link to hook_db_rewrite_sql
This fix is needed on both:
http://drupaldocs.org/api/4.6/function/_db_rewrite_sql
and
http://drupaldocs.org/api/head/function/_db_rewrite_sql
Comment | File | Size | Author |
---|---|---|---|
#6 | database.inc_4.patch | 616 bytes | fgm |
#5 | database.inc_3.patch | 616 bytes | fgm |
#4 | database.inc_2.patch | 605 bytes | fgm |
Comments
Comment #1
sepeck CreditAttribution: sepeck commenteddrupaldocs has been decommed.
Comment #2
fgmError is still there on API:
http://api.drupal.org/api/HEAD/function/_db_rewrite_sql
http://api.drupal.org/api/4.7/function/_db_rewrite_sql
http://api.drupal.org/api/4.6/function/_db_rewrite_sql
All mention the nonexistent
hook_sql
Comment #3
pwolanin CreditAttribution: pwolanin commentedeveryone who has CVS access can commit changes to the developer docs- so just check them out, change and commit. There's no real need to post an issue if you find an obvious error like this.
$ cvs co contributions/docs/developer
Comment #4
fgmThis is not in the docs, but in core, which I'm not even able to commit to. Here are the three patches, for 4.6, 4.7 and HEAD.
First HEAD.
Comment #5
fgmNow 4.7
Comment #6
fgmAnd finally 4.6.
Comment #7
pwolanin CreditAttribution: pwolanin commentedoh, yes- sorry. However, in that case the issue needs to be against Drupal, since otherwise the changes to the code comments will never be noticed and read by the core committers.
Comment #8
pwolanin CreditAttribution: pwolanin commentedthis is trivial and should be committed ASAP
Comment #9
drummCommitted to 5.
Comment #10
Dries CreditAttribution: Dries commentedCommitted to all branches. :)
Comment #11
(not verified) CreditAttribution: commented