The current doc says:

"Collects JOIN and WHERE statements via hook_sql"

It seems it should say:

"Collects JOIN and WHERE statements via hook_db_rewrite_sql" instead, and link to hook_db_rewrite_sql

This fix is needed on both:
http://drupaldocs.org/api/4.6/function/_db_rewrite_sql
and
http://drupaldocs.org/api/head/function/_db_rewrite_sql

CommentFileSizeAuthor
#6 database.inc_4.patch616 bytesfgm
#5 database.inc_3.patch616 bytesfgm
#4 database.inc_2.patch605 bytesfgm
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

sepeck’s picture

Status: Active » Closed (fixed)

drupaldocs has been decommed.

fgm’s picture

pwolanin’s picture

everyone who has CVS access can commit changes to the developer docs- so just check them out, change and commit. There's no real need to post an issue if you find an obvious error like this.

$ cvs co contributions/docs/developer

fgm’s picture

FileSize
605 bytes

This is not in the docs, but in core, which I'm not even able to commit to. Here are the three patches, for 4.6, 4.7 and HEAD.

First HEAD.

fgm’s picture

FileSize
616 bytes

Now 4.7

fgm’s picture

Status: Active » Needs review
FileSize
616 bytes

And finally 4.6.

pwolanin’s picture

Project: Documentation » Drupal core
Version: » 5.x-dev
Component: Developer Guide » database system

oh, yes- sorry. However, in that case the issue needs to be against Drupal, since otherwise the changes to the code comments will never be noticed and read by the core committers.

pwolanin’s picture

Status: Needs review » Reviewed & tested by the community

this is trivial and should be committed ASAP

drumm’s picture

Version: 5.x-dev » 6.x-dev

Committed to 5.

Dries’s picture

Status: Reviewed & tested by the community » Fixed

Committed to all branches. :)

Anonymous’s picture

Status: Fixed » Closed (fixed)