Problem/Motivation

  • In the cleanup scripts both for aws and k8s, the --target resource option works only when the option is set in the end.
  • If it is set in the middle, the remaining options are not parsed.

Issue fork cloud-3281678

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

kumikoono created an issue. See original summary.

kumikoono opened merge request !977

kumikoono’s picture

kumikoono CreditAttribution: kumikoono at DOCOMO Innovations, Inc. commented
Status: Active » Needs review

@onotm @yas Can you review this patch?

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas as a volunteer and at DOCOMO Innovations, Inc. commented
Issue summary: View changes

@kumikoono

Thank you for the patch. It looks good to me.

@onotm

What do you think?

Thanks

onotm’s picture

onotm CreditAttribution: onotm commented
Status: Needs review » Reviewed & tested by the community

@kumikoono It looks good.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas as a volunteer and at DOCOMO Innovations, Inc. commented
Title: Fix option parsing in the resource cleanup scripts for BDD testing » Fix the logic to parse options in the resource cleanup scripts for BDD testing
Issue summary: View changes

@onotm

Thank you for your review.

@kumikoono

I'll merge the patch to 4.x and 5.x, and close this issue as Fixed.

  • yas committed 1c2db39 on 5.x authored by kumikoono 
    Issue #3281678 by kumikoono, yas, onotm: Fix the logic to parse options...

  • yas committed d1556b5 on 4.x authored by kumikoono 
    Issue #3281678 by kumikoono, yas, onotm: Fix the logic to parse options...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas as a volunteer and at DOCOMO Innovations, Inc. commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.