Problem/Motivation

Unable to display wizard settings

Steps to reproduce

  • create form with multiple page
  • go to webform entity -> settings -> form
  • on "FORM CUSTOM SETTINGS", make sure that "POST(default)" is selected
What is expected

"Wizard settings" form fieldset appears.

What we get

Wizard settings" form fieldset stay hidden like a ninja !

Proposed resolution

On src/EntitySettings/WebformEntitySettingsFormForm.php at line 299, we can see that the fieldset appears when input name "method" is empty. But there is no input with "method" as name on form.

I think the field that is referenced is the select name "form_method", line 618.

I propose to replace :

':input[name="method"]' => ['value' => '']

with :

'select[name="form_method"]' => ['value' => '']

CommentFileSizeAuthor
#2 webform-wizard-settings-hidden-3281363-1.patch1.3 KBVieilOurs
Screenshot_1.png56.31 KBVieilOurs
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

VieilOurs created an issue. See original summary.

VieilOurs’s picture

VieilOurs CreditAttribution: VieilOurs commented
FileSize
webform-wizard-settings-hidden-3281363-1.patch1.3 KB

here is a patch

cilefen’s picture

cilefen CreditAttribution: cilefen commented
Status: Active » Needs review
jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented

Good catch! Here is what triggered the regression. #3240399: Move form #method and #action from properties to settings

jannakha’s picture

jannakha CreditAttribution: jannakha as a volunteer and at Tomato Elephant Studio for Australian Competition and Consumer Commission (ACCC) commented
Status: Needs review » Reviewed & tested by the community

works on 6.1.3

thanks for the fix!

VladimirAus’s picture

VladimirAus
Primary language English
Location Brisbane 🇦🇺
CreditAttribution: VladimirAus at Tomato Elephant Studio for Australian Competition and Consumer Commission (ACCC) commented

Also fixes issue for 6.2.0-beta2 when Wizards are always visible regardless of the method.
Thank you.

  • jrockowitz committed 2a9a212 on 6.1.x authored by VieilOurs 
    Issue #3281363 by VieilOurs: Entity settings - wizard settings don't...

  • jrockowitz committed 2a9a212 on 6.x authored by VieilOurs 
    Issue #3281363 by VieilOurs: Entity settings - wizard settings don't...

  • jrockowitz committed 2a9a212 on 6.2.x authored by VieilOurs 
    Issue #3281363 by VieilOurs: Entity settings - wizard settings don't...
jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented
Status: Reviewed & tested by the community » Fixed

@VieilOurs Thanks for the patch.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.