• Add a BDD test suite for Services

Issue fork cloud-3281266

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

shota niioka created an issue. See original summary.

shota niioka opened merge request !963

shota niioka’s picture

shota niioka CreditAttribution: shota niioka commented
Status: Active » Needs review

Could you review this patch ?
Thanks.

yas made their first commit to this issue’s fork.

kumikoono’s picture

kumikoono CreditAttribution: kumikoono at DOCOMO Innovations, Inc. commented
Status: Needs review » Needs work

Can you update this patch based on my comments for https://www.drupal.org/project/cloud/issues/3281025?

kumikoono’s picture

kumikoono CreditAttribution: kumikoono at DOCOMO Innovations, Inc. commented

@s_niioka Can you update the patch?

shota niioka’s picture

shota niioka CreditAttribution: shota niioka commented
Title: Add a BDD test suite for K8s Services (Read and Update) » Add a BDD test suite for K8s Services (Read)
Status: Needs work » Active

shota niioka closed merge request !963

shota niioka opened merge request !1129

shota niioka’s picture

shota niioka CreditAttribution: shota niioka commented

I added read scenario ,
Could you review this patch ?
Thanks.

shota niioka’s picture

shota niioka CreditAttribution: shota niioka commented
Status: Active » Needs review
kumikoono’s picture

kumikoono CreditAttribution: kumikoono at DOCOMO Innovations, Inc. commented
Status: Needs review » Reviewed & tested by the community

This looks good to me. Thanks!

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas as a volunteer and at DOCOMO Innovations, Inc. commented
Issue summary: View changes

@kumikoono

Thank you for your review.

@shota-niioka

I'll merge the patch to 4.x and 5.x, and close this issue as Fixed

  • yas committed b9c6584 on 5.x authored by shota niioka 
    Issue #3281266 by shota niioka, kumikoono, yas: Add a BDD test suite for...

  • yas committed 0bffa24 on 4.x authored by shota niioka 
    Issue #3281266 by shota niioka, kumikoono, yas: Add a BDD test suite for...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas as a volunteer and at DOCOMO Innovations, Inc. commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.