eca_base: Provide an action for translating text [#3280069]

Problem/Motivation

Several places within ECA make sense to run through translation. Using dynamic variables passing to the translation method however is not recommended. We need to determine how we can support translation of text.

Steps to reproduce

Proposed resolution

One way could be to provide an action that runs explicit translation on a dynamic string. This way a user may have the control when and how a string shall be translated.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork eca-3280069

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3280069-ecabase-provide-an changes, plain diff MR !226
Check out this branch

About issue forks

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

12 May 2022 at 08:51

mxh created an issue. See original summary.

Comment #2

mxh

German

Offenburg

CreditAttribution: mxh as a volunteer and at OpenCampus GmbH commented 12 May 2022 at 10:59

This is a follow-up from #3276448: eca_form: Feature clarification

Comment #3

mxh

German

Offenburg

CreditAttribution: mxh as a volunteer and at OpenCampus GmbH commented 20 May 2022 at 08:39

Issue tags:		+release1.0
Parent issue:		» #3238206: ECA 1.0.0 stable release plan

Comment #4

jurgenhaas

he/him

German

Gottmadingen

CreditAttribution: jurgenhaas at LakeDrops commented 15 June 2022 at 11:18

Issue tags:	-release1.0
Parent issue:	#3238206: ECA 1.0.0 stable release plan	»

Will not be part of 1.0RC and may be pushed into 1.1

Comment #5

mxh

German

Offenburg

CreditAttribution: mxh as a volunteer and at OpenCampus GmbH commented 26 August 2022 at 14:26

Assigned:

Unassigned

» mxh

Comment #6

mxh

German

Offenburg

CreditAttribution: mxh as a volunteer and at OpenCampus GmbH commented 26 August 2022 at 14:40

Title:

Determine how to deal with dynamic translation strings

» eca_base: Provide an action for translating text

Comment #7

26 August 2022 at 17:08

mxh opened merge request !226

Comment #8

mxh

German

Offenburg

CreditAttribution: mxh as a volunteer and at OpenCampus GmbH commented 26 August 2022 at 17:10

Assigned:	mxh	» Unassigned
Status:	Active	» Needs review

Comment #9

29 August 2022 at 09:33

jurgenhaas committed de59611 on 1.1.x authored by mxh

Issue #3280069 by mxh, jurgenhaas: eca_base: Provide an action for...

Comment #10

jurgenhaas

he/him

German

Gottmadingen

CreditAttribution: jurgenhaas at LakeDrops commented 29 August 2022 at 09:33

Status:

Needs review

» Fixed

Nicely done!

Comment #11

mxh

German

Offenburg

CreditAttribution: mxh as a volunteer and at OpenCampus GmbH commented 29 August 2022 at 09:54

Parent issue:

» #3281715: Provide a new module "eca_render" for various rendering capabilities

I think it makes sense to move this action to the new eca_render module, once it's available.

Comment #12

jurgenhaas

he/him

German

Gottmadingen

CreditAttribution: jurgenhaas at LakeDrops commented 29 August 2022 at 09:58

Really? I would have thought, translating a string is well-placed as a base plugin because it could be useful for displaying messages, setting form buttons and certainly a lot more.