Problem/Motivation

There is a very small usage of the deprecated ${} (dollar-outside) string interpolation method in Webform, in WebformSubmissionListBuilderCustomizeTest.php

https://wiki.php.net/rfc/deprecate_dollar_brace_string_interpolation

Proposed resolution

This should be updated to use braces-outside. As in ${base_path} -> {$base_path}

CommentFileSizeAuthor
#10 test3.jpg103.99 KBWagnerMelo
#10 test2.jpg171.16 KBWagnerMelo
#10 test.jpg115.75 KBWagnerMelo

Issue fork webform-3279988

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dpi created an issue. See original summary.

matheusmaciel’s picture

matheusmaciel CreditAttribution: matheusmaciel at CI&T commented
Assigned: Unassigned » matheusmaciel

I'll try to work on it.

jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented
Version: 6.2.x-dev » 6.1.x-dev

Thanks. Please target 6.1.x

matheusmaciel opened merge request !184

matheusmaciel’s picture

matheusmaciel CreditAttribution: matheusmaciel at CI&T commented
Assigned: matheusmaciel » Unassigned
Status: Active » Needs review

I just submitted my first push to the Webform, actually the first one in the Drupal community, it'd be nice if someone could review it!
I changed the deprecated code as requested.

Liam Morland’s picture

Liam Morland
Primary language English
Location Ontario, CA 🇨🇦
CreditAttribution: Liam Morland at University of Waterloo commented
Status: Needs review » Reviewed & tested by the community

Looks good. Thanks

Liam Morland’s picture

Liam Morland
Primary language English
Location Ontario, CA 🇨🇦
CreditAttribution: Liam Morland at University of Waterloo commented
Status: Reviewed & tested by the community » Needs work

There is also one in tests/src/Functional/Element/WebformElementTableTest.php.

matheusmaciel’s picture

matheusmaciel CreditAttribution: matheusmaciel at CI&T commented
Assigned: Unassigned » matheusmaciel

Alright, I'll work on it as well.

matheusmaciel’s picture

matheusmaciel CreditAttribution: matheusmaciel at CI&T commented
Assigned: matheusmaciel » Unassigned
Status: Needs work » Needs review

I just changed the deprecated code from tests/src/Functional/Element/WebformElementTableTest.php

WagnerMelo’s picture

WagnerMelo CreditAttribution: WagnerMelo at CI&T commented
Status: Needs review » Reviewed & tested by the community
FileSize
test.jpg115.75 KB
test2.jpg171.16 KB
test3.jpg103.99 KB

I reviewed this issue, and everything works ok.

jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented
Status: Reviewed & tested by the community » Fixed

Liam Morland’s picture

Liam Morland
Primary language English
Location Ontario, CA 🇨🇦
CreditAttribution: Liam Morland at University of Waterloo commented

Thanks everyone. @matheusmaciel, congratulations on your first commit!

dpi’s picture

dpi
Location Perth, Australia
CreditAttribution: dpi at PreviousNext commented

Congrats!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.