Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
- Add a BDD test suite for launching template(git)
Issue fork cloud-3279817
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
makoto suzuki CreditAttribution: makoto suzuki commentedComment #3
makoto suzuki CreditAttribution: makoto suzuki commentedComment #6
makoto suzuki CreditAttribution: makoto suzuki commentedComment #7
makoto suzuki CreditAttribution: makoto suzuki commentedComment #8
kumikoono CreditAttribution: kumikoono at DOCOMO Innovations, Inc. commentedThanks for your providing this patch. Can you check my comments?
Comment #9
makoto suzuki CreditAttribution: makoto suzuki commentedComment #10
kumikoono CreditAttribution: kumikoono at DOCOMO Innovations, Inc. commentedThanks for the update. Except missing a whitespace , it looks good.
Comment #11
makoto suzuki CreditAttribution: makoto suzuki commentedThank you for making sure.
I added whitespace and rebase done.
Comment #12
makoto suzuki CreditAttribution: makoto suzuki commentedComment #13
kumikoono CreditAttribution: kumikoono at DOCOMO Innovations, Inc. commentedThanks for your update. It looks good to me.
Comment #14
yas@kumikoono
Thank you for your review. I'll merge the patch to
4.x
and5.x
, and close this issue as Fixed.Comment #17
makoto suzuki CreditAttribution: makoto suzuki commentedComment #18
yas@makoto-suzuki
Thank you for the update. I posted my comment. Could you please check it? Thanks!
Comment #19
makoto suzuki CreditAttribution: makoto suzuki commentedComment #20
yas@makoto-suzuki
Thank you for the update. It looks good to me now. I'll merge the patch to
4.x
and5.x
, and close this issue as Fixed.Comment #23
yasComment #24
kumikoono CreditAttribution: kumikoono at DOCOMO Innovations, Inc. commentedThis needs to address the merge conflict.
Comment #26
makoto suzuki CreditAttribution: makoto suzuki commentedComment #27
kumikoono CreditAttribution: kumikoono at DOCOMO Innovations, Inc. commentedThanks for the fix.
Comment #28
yas@kumikoono
Thank you for your review.
@makoto-suzuki
I'll merge the patch to
4.x
and5.x
, and close this issue as Fixed.Comment #31
yasComment #32
makoto suzuki CreditAttribution: makoto suzuki commentedChange the launch user of the launch template from cloud administrator to BDD user.
Comment #34
makoto suzuki CreditAttribution: makoto suzuki commentedI changed the run of launch a launch template from cloud adminitrator role to BDD user and ran run_behat.
I was able to browse the deployment pod without any problems.
Modify isssu and submit a review request.
Comment #35
makoto suzuki CreditAttribution: makoto suzuki commentedComment #36
kumikoono CreditAttribution: kumikoono at DOCOMO Innovations, Inc. commentedThanks for your update. It looks good to me.
Comment #37
yas@kumikoono
Thank you for your review.
@makoto-suzuki
Thank you for the hotfix. I'll merge the patch to
4.x
and5.x
, and close this issue as Fixed.Comment #39
yas