Problem/Motivation

Currently, the LateOrderProcessor invokes a save on shipments.

This needs to be skipped in certain situations. This adds a method to determine if the save should occur, allowing other modules to decorate the service and override when needed.

CommentFileSizeAuthor
#6 3279815-6.patch1.56 KBjsacksick
#3 enhance-late-order-processor-3279815-3.patch1.34 KBTomTech
#2 enhance-late-order-processor-3279815-2.patch1.03 KBTomTech
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

TomTech created an issue. See original summary.

TomTech’s picture

TomTech CreditAttribution: TomTech commented
Status: Active » Needs review
FileSize
enhance-late-order-processor-3279815-2.patch1.03 KB
TomTech’s picture

TomTech CreditAttribution: TomTech commented
FileSize
enhance-late-order-processor-3279815-3.patch1.34 KB

Changed shouldSave() to accept ShipmentInterface rather than OrderInterface.

jsacksick’s picture

jsacksick CreditAttribution: jsacksick at Centarro commented
Status: Needs review » Needs work

Almost good! We should make 2 small changes though:

shouldSave() should be made protected and should basically contain the following:

protected function shouldSave(ShipmentInterface $shipment) {
  return $shipment->hasTranslationChanges();
}

So we only call shouldSave().

  • jsacksick committed 1348cc4 on 8.x-2.x authored by TomTech 
    Issue #3279815 by TomTech, jsacksick: Allow LateOrderProcessor to skip...
jsacksick’s picture

jsacksick CreditAttribution: jsacksick at Centarro commented
Status: Needs work » Fixed
FileSize
3279815-6.patch1.56 KB

Made the changes, and committed the patch, attaching it for reference.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.