Problem/Motivation

According to #2706941: Translations of metatags are limited to 128 characters, we can set title metatag for 255 characters length but it is not possible to translate this value because field is limited to 128 characters.

Steps to reproduce

  • Create metatag with title for 200 characters long
  • try to translate this value, you can not change any character because your filed is limited to 128
  • clear all value in this field
  • you can input only to 128 characters

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#7 metatag-n3278924-7.patch2.83 KBDamienMcKenna
#2 metatag-3278924-2.patch443 byteslamp5
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

lamp5 created an issue. See original summary.

lamp5’s picture

lamp5
Primary language Polish
Location Rzeszow
CreditAttribution: lamp5 at abventor commented
Status: Active » Needs review
FileSize
metatag-3278924-2.patch443 bytes

Status: Needs review » Needs work

The last submitted patch, 2: metatag-3278924-2.patch, failed testing. View results

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented

What form shows the title being limited to 128 characters?

lamp5’s picture

lamp5
Primary language Polish
Location Rzeszow
CreditAttribution: lamp5 at abventor commented
Issue summary: View changes
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs work » Needs review

I reran the tests and it worked the second time.

I see that this is the same change that we had in #2706941, so there's precedent for this change.

I wonder if we should just change all meta tag definitions to "type: label"?

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
FileSize
metatag-n3278924-7.patch2.83 KB

Let's update all "title" tags so that they use a type of "text".

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Parent issue: » #3257295: Plan for Metatag 8.x-1.20
lamp5’s picture

lamp5
Primary language Polish
Location Rzeszow
CreditAttribution: lamp5 at abventor commented

Looks great!

  • DamienMcKenna committed 253e946 on 8.x-1.x authored by lamp5 
    Issue #3278924 by lamp5, DamienMcKenna: Translation of title metatag is...
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs review » Fixed

Committed. Thank you.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.