Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Within Olivero, the progress indicator bar percentage label doesn't look quite right. You can see this using the CD_Tools module and at https://tugboat-aqrmztryfqsezpvnghut1cszck2wwasr.tugboat.qa/progress
Comment | File | Size | Author |
---|---|---|---|
#13 | Progress_Indicators___Olivero-2.png | 103.42 KB | mherchel |
Progress_Indicators___bartik.png | 70.67 KB | mherchel | |
Progress_Indicators___Olivero.png | 87.02 KB | mherchel |
Issue fork drupal-3277557
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
rootworkTagging as novice for Portland contrib
Comment #3
galactus86 CreditAttribution: galactus86 as a volunteer and at Mediacurrent commentedI am going to work on this.
Comment #4
rootworkTurned out testing this had some dependencies :)
1. We got DrupalPod installed.
2. We figured out how to add an SSH key in DrupalPod.
3. We figured out how to get a GitHub token so we could `composer require` https://github.com/zolhorvath/cd_tools from GH, in DrupalPod. CD Tools is part of Olivero testing (mentioned in IS).
4. We read How to contribute to Olivero.
4. We figured out how to install yarn and compile postCSS into CSS.
5. We read Olivero's (Claro's) CSS coding standards.
The CSS fix is straightforward, but it took a bit to get to the point where we could make it. Lots of learning on this little issue!
Comment #6
galactus86 CreditAttribution: galactus86 as a volunteer and at Mediacurrent commented#5 is my first attempt at a merge request. The issue itself is a simple CSS change. Please advise if my MR is incorrect or any tips. thx
Comment #7
mherchel@galactus86
Thanks for the patch! There are a couple issues.
yarn build:css
oryarn watch:css
(and then make the changes)margin-inline-start
), which will be compiled by PostCSS into code that all supported browsers support.1rem
, but 🤷♂️Comment #8
mherchel4. Also, the class name in the CSS isn't preceded by a period (
.
).Comment #9
galactus86 CreditAttribution: galactus86 as a volunteer and at Mediacurrent commentedAdjustments made @mherchel - I ran both watch, build before this latest change and the again after. Just getting the hand of these tools. thanks for the quick response.
Comment #10
mherchelLooking a lot better! Don't forget to set the status afterwards!
Can't pull down and review now, but it looks good. Will check it out tomorrow.
Comment #11
mherchel@galactus86 Looks like the patch is created against 9.5.x (I didn't even know that branch was open). Since you created the MR, you're the only one that can update it. Can you point it against 9.4.x please?
Comment #12
galactus86 CreditAttribution: galactus86 as a volunteer and at Mediacurrent commentedChanged the target branch per @mherchel.
Comment #13
mherchelChanges look perfect. Thanks for the work on this @galactus86 (and @rootwork)
Comment #14
alexpottCommitted 946d5a3 and pushed to 10.0.x. Thanks!
Committed and pushed 2d3c1013ba to 9.5.x and 34318c19ea to 9.4.x. Thanks!
I rolled the fix on top of 10.0.x for you.