The BLT/Behat-related classes from the tests/src and tests/contexts subdirectories are being autoloaded by composer and are interfering with stand-alone Behat testing.

As I understand it, these test classes are now deprecated and were left in the codebase for backwards compatibility.

This patch removes the autoload so the classes will no longer be loaded by default.

CommentFileSizeAuthor
#17 lightning_core_remove_test_code.patch41.89 KBJon Pugh
#15 lightning_core_remove_composer_autoload-3277249-10.patch2.15 MBsylus
#10 lightning_core_remove_composer_autoload-3277249-5.patch712 bytessylus
#8 lightning_core_remove_composer_autoload-3277249-3.patch644 bytessylus
#3 lightning_core_remove_composer_autoload-3277249-3.patch349 bytescameron prince
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

cameron prince created an issue. See original summary.

cameron prince’s picture

cameron prince CreditAttribution: cameron prince as a volunteer and at CivicActions for Centers for Medicare and Medicaid Services commented
Issue summary: View changes
cameron prince’s picture

cameron prince CreditAttribution: cameron prince as a volunteer and at CivicActions for Centers for Medicare and Medicaid Services commented
FileSize
lightning_core_remove_composer_autoload-3277249-3.patch349 bytes
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Title: Remove deprecated test classes » Don't autoload deprecated Behat support code
Category: Support request » Task
Status: Active » Reviewed & tested by the community

The last time the Behat stuff was touched was, apparently, over 2 years ago. And it's adorned with a strongly worded warning that it is old, deprecated, and not to be used.

Since this is causing autoloader issues in the wild, I think it's high time that we removed these classes from the autoloader. The files can stay, for the time being, in case there are naughty projects out there which are using them. But I think more than enough time has passed to require people who are still using this stuff to add it to their own autoloader (and hopefully, to their own project, natively).

Therefore, this patch looks good to me. I'll roll a new minor release after committing it.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x-5.x. Thanks!

sylus’s picture

sylus CreditAttribution: sylus commented
FileSize
lightning_core_remove_composer_autoload-3277249-3.patch644 bytes

I was getting the following so i just did this quick rename which seemed to resolve :)

Fatal error: Trait "Acquia\LightningExtension\Context\AwaitTrait" not found in /var/www/html/modules/contrib/lightning_core/tests/contexts/ViewsContext.behat.inc on line 16
make: *** [docker/Makefile:24: behat] Error 255
Error: Process completed with exit code 2.
skirtley’s picture

skirtley CreditAttribution: skirtley commented

Wanted to bump the patch from @sylus, I think this needs to be merged (or something similar), how the project current sits at 5.10 throws the error sylus pointed out if you run:

blt tests:behat

I also believe it is breaking Acquia pipeline jobs (the same behat related error).

sylus’s picture

sylus CreditAttribution: sylus commented
FileSize
lightning_core_remove_composer_autoload-3277249-5.patch712 bytes
cameron prince’s picture

cameron prince CreditAttribution: cameron prince as a volunteer and at CivicActions for Centers for Medicare and Medicaid Services commented

The tests are deprecated and were only left in place to give those still using them time to pull them into their own project. We see the same error as #8, but worked around the tests remaining in the codebase using this in composer.json:

    "scripts": {
        "post-install-cmd": [
            "rm -rf docroot/modules/contrib/lightning_core/tests"
        ]
    },
alfattal’s picture

alfattal CreditAttribution: alfattal as a volunteer commented

I was having the same issue as @skirtley indicated where Acquia Pipeline jobs kept failing with the behat related error. The fix in #11 seems to complement the patch in #10.

bkosborne’s picture

bkosborne
Primary language English
Location New Jersey, USA
CreditAttribution: bkosborne at Princeton University commented

Same #8 error for me, but I'm puzzled as to why running the tests via BLT causes this problem. I've copied the behat contexts to my own folder, added them to my composer classmap. Why is BLT still even looking at ViewsContext.behat.inc file from lighting_core? It shouldn't even know about it. Strange.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

sylus’s picture

sylus CreditAttribution: sylus commented
FileSize
lightning_core_remove_composer_autoload-3277249-10.patch2.15 MB
smulvih2’s picture

smulvih2
Location Canada 🍁
CreditAttribution: smulvih2 at OpenPlus, Cinder Systems Corp. commented

#11 worked for me.

Jon Pugh’s picture

Jon Pugh
he/him
Primary language English
Location Newburgh, NY
CreditAttribution: Jon Pugh at ThinkDrop for DevShop Support commented
FileSize
lightning_core_remove_test_code.patch41.89 KB

FWIW I am still getting the error. I had to fully remove the .behat.inc files to get bin/behat to run.

drupal/lightning_core * 5.14.0
behat/behat v3.13.0
drupal/drupal-extension v5.0.0rc1