Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
Reported by @nod_ and @lauriii in #3248425: Ensure that all classes and functions in Drupal-specific CKEditor 5 plugins are documented 👍
There's some crufty conversions happening in core/modules/ckeditor5/js/ckeditor5_plugins/drupalImage/src/imageupload/drupalimageuploadadapter.js
.
Proposed resolution
Use response.entity_type
in DrupalImageUploadEditing
.
Remaining tasks
TBD
User interface changes
None.
API changes
None.
Data model changes
None.
Comment | File | Size | Author |
---|---|---|---|
#9 | 3275237-9-d93.patch | 36.5 KB | lauriii |
#9 | 3275237-9-d95.patch | 36.5 KB | lauriii |
Issue fork drupal-3275237
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3275237-dont-convert-instead changes, plain diff MR !2223
Comments
Comment #4
Wim LeersComment #7
Wim LeersThe merge request looks delightfully simple! 🤩
Looks like this is crashing at least one functional JS test:
CKEditor5Test
😅Comment #8
Wim LeersLooks ready now! 😄
Comment #9
lauriiiComment #14
lauriiiCommitted b51ab0d and pushed to 10.0.x. Also committed #9 to 9.5.x and cherry-picked to 9.4.x. Thanks!
Leaving open for a 9.3.x commit once the freeze is over.
Comment #15
larowlanUpdating status
Comment #16
Wim LeersNot yet backported 😅
Comment #18
Wim LeersComment #19
lauriiiCommitted f5aced4 and pushed to 9.3.x. Thanks!