PHP 8.1 compatibility for Views [#3274056]

Fix all PHP 8.1 compatibility issues in Views so that the tests can run correctly.

Comment	File	Size	Author
#6	views-n3274056-6.patch	1.42 KB	DamienMcKenna
#6	7.x-3.x: PHP 8.1 & MySQL 5.7, D7 234 pass, 4 fail
#4	views-n3274056-4.patch	539 bytes	DamienMcKenna
#4	7.x-3.x: PHP 7.4 & MySQL 5.5, D7 234 pass PHP 8.1 & MySQL 5.7, D7 234 pass, 4 fail

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

7 April 2022 at 16:54

DamienMcKenna created an issue. See original summary.

Comment #2

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 7 April 2022 at 16:56

The current tests show the following:

ViewsArgumentDefaultTest
testArgumentDefaultNoOptions
✗	
drupal_validate_utf8
exception: [Deprecated function] Line 1936 of includes/bootstrap.inc:
strlen(): Passing null to parameter #1 ($string) of type string is deprecated
✗	
filter_xss
exception: [Deprecated function] Line 1503 of includes/common.inc:
str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated

ViewsHandlerSortDateTest
testDateOrdering
✗	
views_get_timezone
exception: [Deprecated] Line 1249 of sites/all/modules/views/includes/handlers.inc:
strlen(): Passing null to parameter #1 ($string) of type string is deprecated

exception: [Deprecated] Line 1249 of sites/all/modules/views/includes/handlers.inc:
strlen(): Passing null to parameter #1 ($string) of type string is deprecated

exception: [Deprecated] Line 1249 of sites/all/modules/views/includes/handlers.inc:
strlen(): Passing null to parameter #1 ($string) of type string is deprecated

exception: [Deprecated] Line 1249 of sites/all/modules/views/includes/handlers.inc:
strlen(): Passing null to parameter #1 ($string) of type string is deprecated

exception: [Deprecated] Line 1249 of sites/all/modules/views/includes/handlers.inc:
strlen(): Passing null to parameter #1 ($string) of type string is deprecated

exception: [Deprecated] Line 1249 of sites/all/modules/views/includes/handlers.inc:
strlen(): Passing null to parameter #1 ($string) of type string is deprecated

exception: [Deprecated] Line 1249 of sites/all/modules/views/includes/handlers.inc:
strlen(): Passing null to parameter #1 ($string) of type string is deprecated

exception: [Deprecated] Line 1249 of sites/all/modules/views/includes/handlers.inc:
strlen(): Passing null to parameter #1 ($string) of type string is deprecated

exception: [Deprecated] Line 1249 of sites/all/modules/views/includes/handlers.inc:
strlen(): Passing null to parameter #1 ($string) of type string is deprecated

exception: [Deprecated] Line 1249 of sites/all/modules/views/includes/handlers.inc:
strlen(): Passing null to parameter #1 ($string) of type string is deprecated

ViewsUpgradeTestCase
✗	
drupal_validate_utf8
exception: [Deprecated function] Line 1936 of includes/bootstrap.inc:
strlen(): Passing null to parameter #1 ($string) of type string is deprecated

exception: [Deprecated function] Line 1936 of includes/bootstrap.inc:
strlen(): Passing null to parameter #1 ($string) of type string is deprecated
✗	
filter_xss
exception: [Deprecated function] Line 1503 of includes/common.inc:
str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated

exception: [Deprecated function] Line 1503 of includes/common.inc:
str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated

ViewsViewTest
views_get_timezone
exception: [Deprecated] Line 1249 of sites/all/modules/views/includes/handlers.inc:
strlen(): Passing null to parameter #1 ($string) of type string is deprecated

exception: [Deprecated] Line 1249 of sites/all/modules/views/includes/handlers.inc:
strlen(): Passing null to parameter #1 ($string) of type string is deprecated

exception: [Deprecated] Line 1249 of sites/all/modules/views/includes/handlers.inc:
strlen(): Passing null to parameter #1 ($string) of type string is deprecated

exception: [Deprecated] Line 1249 of sites/all/modules/views/includes/handlers.inc:
strlen(): Passing null to parameter #1 ($string) of type string is deprecated

exception: [Deprecated] Line 1249 of sites/all/modules/views/includes/handlers.inc:
strlen(): Passing null to parameter #1 ($string) of type string is deprecated

exception: [Deprecated] Line 1249 of sites/all/modules/views/includes/handlers.inc:
strlen(): Passing null to parameter #1 ($string) of type string is deprecated

exception: [Deprecated] Line 1249 of sites/all/modules/views/includes/handlers.inc:
strlen(): Passing null to parameter #1 ($string) of type string is deprecated

exception: [Deprecated] Line 1249 of sites/all/modules/views/includes/handlers.inc:
strlen(): Passing null to parameter #1 ($string) of type string is deprecated

exception: [Deprecated] Line 1249 of sites/all/modules/views/includes/handlers.inc:
strlen(): Passing null to parameter #1 ($string) of type string is deprecated

exception: [Deprecated] Line 1249 of sites/all/modules/views/includes/handlers.inc:
strlen(): Passing null to parameter #1 ($string) of type string is deprecated

exception: [Deprecated] Line 1249 of sites/all/modules/views/includes/handlers.inc:
strlen(): Passing null to parameter #1 ($string) of type string is deprecated

exception: [Deprecated] Line 1249 of sites/all/modules/views/includes/handlers.inc:
strlen(): Passing null to parameter #1 ($string) of type string is deprecated

exception: [Deprecated] Line 1249 of sites/all/modules/views/includes/handlers.inc:
strlen(): Passing null to parameter #1 ($string) of type string is deprecated

exception: [Deprecated] Line 1249 of sites/all/modules/views/includes/handlers.inc:
strlen(): Passing null to parameter #1 ($string) of type string is deprecated

exception: [Deprecated] Line 1249 of sites/all/modules/views/includes/handlers.inc:
strlen(): Passing null to parameter #1 ($string) of type string is deprecated

exception: [Deprecated] Line 1249 of sites/all/modules/views/includes/handlers.inc:
strlen(): Passing null to parameter #1 ($string) of type string is deprecated

exception: [Deprecated] Line 1249 of sites/all/modules/views/includes/handlers.inc:
strlen(): Passing null to parameter #1 ($string) of type string is deprecated

exception: [Deprecated] Line 1249 of sites/all/modules/views/includes/handlers.inc:
strlen(): Passing null to parameter #1 ($string) of type string is deprecated

exception: [Deprecated] Line 1249 of sites/all/modules/views/includes/handlers.inc:
strlen(): Passing null to parameter #1 ($string) of type string is deprecated

exception: [Deprecated] Line 1249 of sites/all/modules/views/includes/handlers.inc:
strlen(): Passing null to parameter #1 ($string) of type string is deprecated

exception: [Deprecated] Line 1249 of sites/all/modules/views/includes/handlers.inc:
strlen(): Passing null to parameter #1 ($string) of type string is deprecated

exception: [Deprecated] Line 1249 of sites/all/modules/views/includes/handlers.inc:
strlen(): Passing null to parameter #1 ($string) of type string is deprecated

exception: [Deprecated] Line 1249 of sites/all/modules/views/includes/handlers.inc:
strlen(): Passing null to parameter #1 ($string) of type string is deprecated

exception: [Deprecated] Line 1249 of sites/all/modules/views/includes/handlers.inc:
strlen(): Passing null to parameter #1 ($string) of type string is deprecated

exception: [Deprecated] Line 1249 of sites/all/modules/views/includes/handlers.inc:
strlen(): Passing null to parameter #1 ($string) of type string is deprecated

exception: [Deprecated] Line 1249 of sites/all/modules/views/includes/handlers.inc:
strlen(): Passing null to parameter #1 ($string) of type string is deprecated

exception: [Deprecated] Line 1249 of sites/all/modules/views/includes/handlers.inc:
strlen(): Passing null to parameter #1 ($string) of type string is deprecated

exception: [Deprecated] Line 1249 of sites/all/modules/views/includes/handlers.inc:
strlen(): Passing null to parameter #1 ($string) of type string is deprecated

exception: [Deprecated] Line 1249 of sites/all/modules/views/includes/handlers.inc:
strlen(): Passing null to parameter #1 ($string) of type string is deprecated

exception: [Deprecated] Line 1249 of sites/all/modules/views/includes/handlers.inc:
strlen(): Passing null to parameter #1 ($string) of type string is deprecated

Comment #3

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 7 April 2022 at 17:41

There's other detail available via the "views_debug" section of the output.

Comment #4

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 14 April 2022 at 15:47

Status:

Active

» Needs review

File	Size
views-n3274056-4.patch	539 bytes
7.x-3.x: PHP 7.4 & MySQL 5.5, D7 234 pass PHP 8.1 & MySQL 5.7, D7 234 pass, 4 fail

This should resolve the problem with includes/handlers.inc.

Comment #5

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 14 April 2022 at 18:26

Status:

Needs review

» Needs work

Needs further work.

Comment #6

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 14 April 2022 at 18:32

Status:

Needs work

» Needs review

File	Size
views-n3274056-6.patch	1.42 KB
7.x-3.x: PHP 8.1 & MySQL 5.7, D7 234 pass, 4 fail

Does this help?

Comment #7

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 14 April 2022 at 19:46

Status:

Needs review

» Needs work

1 file was hidden/shown/deleted

File	Size
views-n3274056-6.patch	1.42 KB
7.x-3.x: PHP 8.1 & MySQL 5.7, D7 234 pass, 4 fail

It's annoying - I can't trigger this error locally.

Comment #8

poker10 CreditAttribution: poker10 at ActivIT s.r.o. commented 16 May 2022 at 07:26

These last errors in testbot should hopefully be fixed by #3270546: [D7 PHP 8.1] str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated in filter_xss() in D7 june release.

Comment #9

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 16 May 2022 at 09:45

Status:	Needs work	» Postponed
Related issues:		+#3270546: [D7 PHP 8.1] str_replace(): Passing null to parameter #3 ($subject) of type array\|string is deprecated in filter_xss()

Oh perfect, thank you!

Comment #10

16 May 2022 at 09:49

DamienMcKenna committed b0eedee on 7.x-3.x

Issue #3274056 by DamienMcKenna, poker10: PHP 8.1 compatibility.

Comment #11

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 16 May 2022 at 09:50

Status:	Postponed	» Fixed
Parent issue:		» #3232189: Plan for Views 7.x-3.26

Committed. Thank you poker10.

Comment #12

30 May 2022 at 09:54

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

PHP 8.1 compatibility for Views

Comments

Comment #1

Comment #2

Comment #3

Comment #4

Comment #5

Comment #6

Comment #7

Comment #8

Comment #9

Comment #10

Comment #11

Comment #12

Parent issue

Related issues

Referenced by

Thank you to these Drupal contributors

News items

Our community

Documentation

Drupal code base

Governance of community