The tag condition added in #2883654: Checkout button missing from custom cart form view does not respect the fact that view tag is actually multivalue property.

CommentFileSizeAuthor
#2 commerce-checkout-tag-condition-3271930-2.patch1.1 KBChi
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Chi created an issue. See original summary.

Chi’s picture

Chi CreditAttribution: Chi commented
Status: Active » Needs review
FileSize
commerce-checkout-tag-condition-3271930-2.patch1.1 KB

  • jsacksick committed 1d8aab4 on 8.x-2.x authored by Chi 
    Issue #3271930 by Chi, jsacksick: Checkout button missing from a cart...

  • jsacksick committed 9e58f8c on 3.0.x authored by Chi 
    Issue #3271930 by Chi, jsacksick: Checkout button missing from a cart...
jsacksick’s picture

jsacksick CreditAttribution: jsacksick at Centarro commented
Status: Needs review » Fixed

Thanks for the fix.

The commerce_cart module also has similar code, but does the following:

if (strpos($view->storage->get('tag'), 'commerce_cart_form') !== FALSE) {

Which also works, but kept your approach, just removed the "\" prefix to the in_array call, and added strict type checking... Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.