Problem/Motivation

We want to make sure that createDropdown() in core/modules/ckeditor5/js/ckeditor5_plugins/drupalMedia/src/drupalelementstyle/drupalelementstyleui.js continues to work because it is not used anymore. There is value in keeping it because it gives the ability to create button drop downs in the CKEditor 5 toolbar which could be useful to another module or core since it is not an uncommon use case.

Steps to reproduce

Proposed resolution

Add test coverage to ensure that createDropdown() continues to work.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#13 3270765-13-9.3.x.patch4.83 KBWim Leers

Issue fork drupal-3270765

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

hooroomoo created an issue. See original summary.

hooroomoo’s picture

hooroomoo
they/them
CreditAttribution: hooroomoo at Acquia commented
Issue summary: View changes
Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Assigned: Unassigned » Wim Leers

Thanks!

Adding a test module to make it easy to test this…

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Assigned: Wim Leers » lauriii
Status: Active » Needs work

Here's the test-only module. This was surprisingly tricky 😬

lauriii made their first commit to this issue’s fork.

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ at Acquia commented
Status: Needs work » Reviewed & tested by the community

Looks good to me. Not sure how to test it outside the test, but the test itself makes sense.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Issue tags: -Needs tests +JavaScript
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii at Acquia commented
Assigned: lauriii » Unassigned
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed fe3d2efd97 to 10.0.x and 3d794cf653 to 9.4.x. Thanks!

  • alexpott committed fe3d2ef on 10.0.x 
    Issue #3270765 by Wim Leers, lauriii: Add test coverage for...

  • alexpott committed 3d794cf on 9.4.x 
    Issue #3270765 by Wim Leers, lauriii: Add test coverage for...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Version: 9.4.x-dev » 9.3.x-dev

Re-opening for 9.3.x backport.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Status: Fixed » Needs review
FileSize
3270765-13-9.3.x.patch4.83 KB

Patch from local chery-pick.

lauriii closed merge request !1994

  • lauriii committed 6d95c62 on 9.3.x 
    Issue #3270765 by Wim Leers, lauriii: Add test coverage for...
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii at Acquia commented
Status: Needs review » Fixed

Committed 6d95c62 and pushed to 9.3.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.