Problem/Motivation

Irrespective of conditions operator selected for a shipment method it is always AND that is used when comparing results of order conditions and shipment conditions.

That is, when "Only one condition must pass" option is selected, and a shipping method has both order and shipment conditions, and only one of them passes, the shipping method will not apply.

Steps to reproduce

  • Create a shipping method that has both order conditions (e.g. "Order type") and a shipment condition (e.g. "Shipment weight"), and check "Only one condition must pass" option.
  • Create an order for which only one of the conditions above passes (e.g. passing weight but wrong order type).
  • See the shipping method is not listed on the checkout.

Proposed resolution

Apply the condition operator not only inside order and shipment conditions groups but also between them.

Remaining tasks

N/A

User interface changes

N/A

API changes

N/A

Data model changes

N/A

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Alex Bukach created an issue. See original summary.

Alex Bukach’s picture

Assigned: Alex Bukach » Unassigned
Status: Active » Needs review
FileSize
1.19 KB

  • jsacksick committed ff6fe49 on 8.x-2.x authored by Alex Bukach
    Issue #3269908 by Alex Bukach: Apply conditions operator between order...
jsacksick’s picture

Status: Needs review » Fixed

Looks like a no brainer patch to me! Thank you, committed!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.