Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
This is part of #3267247: [meta] Fix and re-enable tests skipped for random failures, for ContentPreviewToggleTest::testContentPreviewToggle().
See the parent issue for steps to reproduce/proposed resolution.
Comment | File | Size | Author |
---|---|---|---|
#8 | 3268678-8.patch | 2.37 KB | bnjmnm |
#7 | 3268678-7.patch | 2.37 KB | bnjmnm |
Issue fork drupal-3268678
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #4
bnjmnmComment #6
bnjmnmThe MR runs the test 1200x
Comment #7
bnjmnmPatch without the 1200x for committing.
Comment #8
bnjmnmComment #9
phenaproximaGreat! I remember writing OffCanvasTestTrait and if using it is all the fix we need, so much the better. RTBC once green.
Comment #10
alexpottCommitted and pushed dcf0fd3bf9 to 10.1.x and 3fb9459a72 to 10.0.x and b9f1240ce2 to 9.5.x. Thanks!
Committed 1074da8 and pushed to 9.4.x. Thanks!
Comment #13
xjmLooking good! Queued a few more jobs. If something is a 1/1000 fail rate (which is still enough to disrupt core development), there's nearly a 1% chance that running the test 4800 times will not fail even if the fail is still present. Merely doubling that to 9600 makes the chance of not having a fail when a fail is present exponentially small.
Edit: Crosspost. I will watch this space to ensure the jobs pass. :P
Comment #16
xjmAll the jobs are green. 👍