Problem/Motivation

We need to to fix the DI on this method: Drupal\modal_page\Service\ModalPageService::__construct()

Reported by @pgn5qs

CommentFileSizeAuthor
#8 3268347.patch3.37 KBrenatog

Comments

RenatoG created an issue. See original summary.

RenatoG credited pgn5qs.

renatog’s picture

renatog commented
Title: Error after update from 4.1.9 to 4.1.10: ArgumentCountError: Too few arguments to function Drupal\modal_page\Service\ModalPageService::__construct() » Fix the Dependency Injection at ModalPageService::__construct(),
Issue summary: View changes
pgn5qs’s picture

pgn5qs commented

Any progress on this? Same issue with 4.1.12. This is still site breaking. Should it be higher priority than "Normal" since it bricks the site?

renatog’s picture

renatog commented
Priority: Normal » Major

,

renatog’s picture

renatog commented
Priority: Major » Critical

You're right, totally agree. Let's increase the priority for that since you can't use the project with this error

renatog’s picture

renatog commented

This one was the commit https://git.drupalcode.org/project/modal_page/-/commit/2ceca92

renatog’s picture

renatog commented
StatusFileSize
new 3268347.patch3.37 KB

This is the patch with the fix @pgn5qs

  • RenatoG committed cd951dd on 4.1.x 
    Issue #3268347 by RenatoG, pgn5qs: Fix the Dependency Injection at...
renatog’s picture

renatog commented
Status: Active » Fixed

Fixed and moved to the dev branch 4.1.x

renatog’s picture

renatog commented

@pgn5qs, fixed and created a new release https://www.drupal.org/project/modal_page/releases/4.1.13

$ composer require 'drupal/modal_page:^4.1'

Thank you so much for using Modal

pgn5qs’s picture

pgn5qs commented

Thanks everyone. That fixed it. Great team.

renatog’s picture

renatog commented

Amazing! I'm happy to hear that. Thank you so much for your feedback @pgn5qs

P.s. If you like the project, feel free to give us your star in the project page ⭐️

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.