Problem/Motivation
Some titles in the preview section on the edit page of the edit content view admin/structure/views/view/content
have a too low color contrast. The h1
s with a class of section-title
have a contrast ratio of 3.9:1
. For regular text 4.5:1
would be required.
*visualised with the tota11y bookmarklet but cross checked with the color contrast anaylizer
Steps to reproduce
- Go to admin/structure/views/view/content
- Check one of the section-titles: Title
, Exposed Filters
, Content
or Pager
in the Preview section as well as the edit view name/description
and Cancel
button in the Displays
section
Comment | File | Size | Author |
---|---|---|---|
#9 | after.png | 51.83 KB | rkoller |
#9 | before.png | 51.84 KB | rkoller |
#8 | 3266216-10.0.x.patch | 1011 bytes | mherchel |
| |||
#8 | 3266216-9.4.x.patch | 997 bytes | mherchel |
#3 | buttons.png | 182.19 KB | rkoller |
Comments
Comment #2
rkollerComment #3
rkollerComment #4
rkollerExtended the scope of the issue by adding the two grey buttons on grey background. Changed the title and updated the IS
Comment #5
rkollerComment #6
rkollerComment #7
rkollerI've updated the title and IS of the issue. I've removed the part about the buttons since those got a dedicated issue now at https://www.drupal.org/project/drupal/issues/3272266 . so the scope of this issue is simply focused on a single element and the buttons topic applies also to several pages across the admin interface this issue here only to the preview section on a views edit page.
Comment #8
mherchelQuick fix. I updated the color from
#818181
tovar(--color-gray-800)
(#55565b
), which has a 7.32:1 contrast ratio.Comment #9
rkollercool thank you! I've applied the patch and everything looks good and correct. For comparison three of the headlines before the patch:
and after the patch:
Setting the issue to RTBC, since the hex color as well as the variable is taken from the new Claro grey scale ( https://www.drupal.org/project/drupal/issues/3154539 ) and those two lines are the only changes for the patch.
Comment #12
ckrinaCommitted 40ad2f7 and pushed to 10.0.x and 9.4.x. Thanks!