Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
PHPStan identified a duplicate key in MailManagerTest. It seems to have been changed by accident in #2663270: MailManager::mail() should run inside its own render context: it sends e-mails, not (cacheable) responses but there is no mention of why and it doesn't seem to have served a purpose.
Steps to reproduce
PHPStan results.
Proposed resolution
Replace second key with the original key.
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
Comment | File | Size | Author |
---|---|---|---|
#4 | reroll_diff_2-4.txt | 656 bytes | eleonel |
#4 | 3265429-3.patch | 1.17 KB | eleonel |
#2 | 3265429-2.patch | 1.18 KB | neclimdul |
Comments
Comment #2
neclimdulshoot. made that off my test branch and the baseline diff doesn't apply. Realized it after I'd submitted. This should work though.
Comment #3
daffie CreditAttribution: daffie commentedPatch looks good, but does need a reroll.
Comment #4
eleonelComment #5
eleonelComment #6
daffie CreditAttribution: daffie commentedLooks good to me.
Comment #8
daffie CreditAttribution: daffie commentedBack to RTBC.
Comment #9
alexpottCommitted ef36c2e and pushed to 10.0.x. Thanks!
Committed 0bf085b and pushed to 9.5.x. Thanks!
Committed 641bb74 and pushed to 9.4.x. Thanks!
Backported to 9.4.x (minus phpstan changes) as this is a test-only change.