Problem

The 'core_version_requirement' can not be used to specify compatibility for a specific version before 8.7.7 in modules/contrib/transliterate_filenames/transliterate_filenames.info.yml

This update crashes site and also will not allow core (d9.3.5 and php8.1) fresh install when module is present.

Change from

name: Transliterate Filenames for Uploads
type: module
description: Transliterate filenames to latin for uploads
core_version_requirement: ^8.7 || ^9.2

to

name: Transliterate Filenames for Uploads
type: module
description: Transliterate filenames to latin for uploads
core_version_requirement: ^8.7.7 || ^9.2

and all is well

CommentFileSizeAuthor
#9 3263658-9.patch403 bytesvictoria-marina
#7 3263658-7.patch395 bytesvictoria-marina
#3 3263658-3.patch752 bytesvictoria-marina
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

crutch created an issue. See original summary.

victoria-marina’s picture

victoria-marina CreditAttribution: victoria-marina at CI&T commented
Assigned: Unassigned » victoria-marina

I'll work on this.

victoria-marina’s picture

victoria-marina CreditAttribution: victoria-marina at CI&T commented
Assigned: victoria-marina » Unassigned
Status: Active » Needs review
FileSize
3263658-3.patch752 bytes

I was getting an error even after applying the proposed solution in the issue scope, so I made the changes:

  • Relaxes the core_version_requirement in the module's info file (to make the problem reported here go away).
  • Adds the conflict requirement to the Composer config (to keep enforcing the minimum Drupal core version).

Kindly review it.

alphex’s picture

alphex CreditAttribution: alphex commented

This fails to apply against 1.9.

The lines ...

    "conflict": {
        "drupal/core": "<8.7.7"
    }

Are already in the project composer.json.

...
Updating to 2.0 of course works...
I didn't know that was released yet.

Macruz’s picture

Macruz CreditAttribution: Macruz commented

Same problem.

"core_version_requirement: ^8.7.7 || ^9.2"

Worked fine, thx

victoria-marina’s picture

victoria-marina CreditAttribution: victoria-marina at CI&T commented
Assigned: Unassigned » victoria-marina
victoria-marina’s picture

victoria-marina CreditAttribution: victoria-marina at CI&T commented
Assigned: victoria-marina » Unassigned
FileSize
3263658-7.patch395 bytes

Thanks @alphex and @macruz! I made a new patch with the format mentioned.

crutch’s picture

crutch CreditAttribution: crutch commented

Thank you #7 for the patch however it doesn't apply against dev.

change from

-core_version_requirement: ^9.2
+core_version_requirement: ^8.7.7 || ^9.2

to

-core_version_requirement: ^8.7 || ^9.2
+core_version_requirement: ^8.7.7 || ^9.2

victoria-marina’s picture

victoria-marina CreditAttribution: victoria-marina at CI&T commented
Version: 2.0.x-dev » 8.x-1.x-dev
FileSize
3263658-9.patch403 bytes

@crutch thanks for your reply. Changing the issue version to 8.x-1x because the core_version_requirement: ^8.7 || ^9.2 only exists on that version.

Sending a new patch for this version.

crutch’s picture

crutch CreditAttribution: crutch commented

Ah yes, didn't realize 2.0 was released. This patch applied to 1.x-dev, thank you :)

  • ivnish committed 34bdb61 on 8.x-1.x authored by victoria-marina 
    Issue #3263658 by victoria-marina, crutch: The 'core_version_requirement...
ivnish’s picture

ivnish CreditAttribution: ivnish commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.