Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
There's functions deprecated for removal in core 10
Proposed resolution
remove the usage, make sure no mentions left
Remaining tasks
review/commit
User interface changes
no
API changes
no
Data model changes
no
Release notes snippet
Comment | File | Size | Author |
---|---|---|---|
#10 | 3261244-10.patch | 8.1 KB | andypost |
#10 | interdiff.txt | 2.1 KB | andypost |
Comments
Comment #2
andypostComment #4
andypostcan't reproduce locally, re-queued
Comment #5
andypostComment #6
longwaveOne more to go:
Comment #7
andypostThank you! fixed)
Comment #8
longwaveThank you, looks ready now if bot agrees.
Comment #10
andypostremoved legacy test for this constructor arguments
Comment #11
longwaveRTBC for real this time :)
Comment #12
quietone CreditAttribution: quietone at PreviousNext commentedThere are no deprecations in layout_builder.module but there are in the module, so changing title.
Comment #13
quietone CreditAttribution: quietone at PreviousNext commentedLooks good, grep did not find anything.
Comment #15
andypostbot random failure
Comment #16
quietone CreditAttribution: quietone at PreviousNext commentedChecking my review and working on my local process to make sure I check everything. :-)
I applied the patch and re-ran the grep commands.
For a moment I wondered about the adding of the typehint in the layoutBuilder constructor but then I saw the deprecation warning just below. So that is fine.
Adding credit to longwave.
This looks ready to commit to me. I'll wait for another committer to confirm.
Comment #17
catchLast thing here is to check whether deprecations being removed (acutal API changes, not constructor ones and similar) have an issue on https://github.com/mglaman/phpstan-drupal/issues and create one linking to the CR if not. Can be done as part of the commit process. We should start doing that when we add new deprecations in the first place, but doing it on removal was suggested by @xjm as a way to fill in the old gaps. I just did some on #3244802: Remove BC layers in entity system.
Patch looks great to me. Leaving for @quietone to commit.
Comment #18
xjmI think these are the three unique CRs removed by the patch. I checked and this patch removes all references to those three CRs.
Comment #20
quietone CreditAttribution: quietone at PreviousNext commentedCommitted to 10.0.x.
Thank you!
Adding credit to catch and xjm for mentoring support.