Problem/Motivation

In our project we have encountered a bug where a TranslatableMarkup object was passed to a method in SparqlArg which expects strings. This could have been prevented with correct type hints.

CommentFileSizeAuthor
#5 3261101-4.patch7.23 KBclaudiu.cristea
#5 3261101-4.interdiff.txt1.25 KBclaudiu.cristea
#3 3261101-3.interdiff.txt3.04 KBclaudiu.cristea
#3 3261101-3.patch5.98 KBclaudiu.cristea
#2 3261101-2.patch2.94 KBpfrenssen
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

pfrenssen created an issue. See original summary.

pfrenssen’s picture

pfrenssen
Location Sofia
CreditAttribution: pfrenssen at Randstad Digital for European Commission and European Union Institutions, Agencies and Bodies commented
Status: Active » Needs review
FileSize
3261101-2.patch2.94 KB
claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea as a volunteer and at Webikon for European Commission and European Union Institutions, Agencies and Bodies commented
FileSize
3261101-3.interdiff.txt3.04 KB
3261101-3.patch5.98 KB

Fixed CS issues.

pfrenssen’s picture

pfrenssen
Location Sofia
CreditAttribution: pfrenssen at Randstad Digital for European Commission and European Union Institutions, Agencies and Bodies commented

CS fixes look good, thanks!

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea as a volunteer and at Webikon for European Commission and European Union Institutions, Agencies and Bodies commented
FileSize
3261101-4.interdiff.txt1.25 KB
3261101-4.patch7.23 KB

.travis.yml leftover.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea as a volunteer and at Webikon for European Commission and European Union Institutions, Agencies and Bodies commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.