Problem/Motivation

A Drupal 10 alpha is coming very soon #3251854: [META] Requirements for tagging Drupal 10.0.0-alpha1!

It'd be great if token could mark itself as compatible with D10so we can begin the transition. Marking it as D10 compatible means that we intend for the current major (or new major if you prefer?!) to be compatible with D10, even if it is not truely compatible as is.

Steps to reproduce

With a Drupal 10 project, try to composer require drupal/token

Proposed resolution

Update constraints in composer.json and info.yml

Issue fork token-3259259

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dpi created an issue. See original summary.

dpi’s picture

dpi
Location Perth, Australia
CreditAttribution: dpi at PreviousNext commented

I'm opening this since Token is a very common dependency, and to get discussion started.

You can see Drupal CI errors when token is required, as per https://www.drupal.org/pift-ci-job/2298120

- drupal/token[dev-1.x, 1.8.0, ..., 1.10.0] require drupal/core ^8.8 || ^9 -> satisfiable by drupal/core[8.8.0-alpha1, ..., 8.9.x-dev, 9.0.0-alpha1, ..., 9.4.x-dev] from composer repo (https://repo.packagist.org) but drupal/core[10.0.x-dev] from path repo (core) has higher repository priority. The packages with higher priority do not match your constraint and are therefore not installable. See https://getcomposer.org/repoprio for details and assistance.

dpi opened merge request !17

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented

Thanks, yes, this is helpful to check progress. But I don't think I'll be committing this before the tests are actually passing. Caused some weird edge cases in the past where you could install certain versions of the module before it was really compatible. There is an issue for the setUp change that needs review, and also one for the $modules definitions that is already RTBC, after that we should already be able to see some progress with this.

dpi’s picture

dpi
Location Perth, Australia
CreditAttribution: dpi at PreviousNext commented

Thanks @Berdir,

Has there been any consideration for a new major version new dev could be based off?

This should counter the concern where there aren't any 100% compatible versions with a certain dependency, since there would be no stable releases based off this theoretical new major.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented

No, I don't plan to do a new major version. If you want to help push this forward then help with the blocking issues that people are working on.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Active » Needs work

Committed two issues, this needs a rebase as 8.x is no longer supported now.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs work » Needs review

  • Berdir committed 1585138 on 8.x-1.x authored by dpi 
    Issue #3259259 by Berdir, dpi: Mark Token as Drupal 10 [to-be]...
Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Title: Mark Token as Drupal 10 [to-be] compatible » Mark Token as Drupal 10 compatible
Status: Needs review » Fixed

Yay, green, committed.

dpi’s picture

dpi
Location Perth, Australia
CreditAttribution: dpi at PreviousNext commented

Thanks @Berdir, appreciated.

dpi’s picture

dpi
Location Perth, Australia
CreditAttribution: dpi at PreviousNext commented

Another thanks, I'm able to make projects Drupal 10 compatible by getting up to date by removing deprecations, and since these dependencies are declared-ready, I can have an automated runner remind me of new incompatibilities on a weekly basis.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.