Fatal error on viewing node (on drupal.org) [#32584]

Comment	File	Size	Author
#2	book_32.patch	6.04 KB	killes@www.drop.org

Comment #1

killes@www.drop.org CreditAttribution: killes@www.drop.org commented 29 September 2005 at 16:18

Version:	4.6.3	» x.y.z
Priority:	Normal	» Critical

I am at it.

Log in or register to post comments

Comment #2

killes@www.drop.org CreditAttribution: killes@www.drop.org commented 29 September 2005 at 16:38

Status:

Active

» Needs review

File	Size
book_32.patch	6.04 KB

Here is a quickfix which removes the offending function. The feature it was trying to implement was made impossible by the revisions patch. :-/
I suggest moving the "moderate" column from the node to the node_revisions table and then add the feature back.

The patch also fixes an input validation error in the export function.

Log in or register to post comments

Comment #3

Dries CreditAttribution: Dries commented 29 September 2005 at 21:56

Status:

Needs review

» Fixed

Committed to HEAD.

Log in or register to post comments

Comment #4

Gerhard Killesreiter CreditAttribution: Gerhard Killesreiter commented 29 September 2005 at 22:08

Priority:	Critical	» Normal
Status:	Fixed	» Active

How should we procede with the "multiple active versions" feature that used to exist in the book? Consider it scrapped? Rework it somehow?

Log in or register to post comments

Comment #5

Uwe Hermann CreditAttribution: Uwe Hermann commented 24 April 2006 at 04:44

What's the status on this one?

Log in or register to post comments

Comment #6

killes@www.drop.org CreditAttribution: killes@www.drop.org commented 24 April 2006 at 05:05

"nobody cared enough". In principle it should be possible for a moderation module to track updates , get the proviously active revision, set that to active again, and display the new revision in its queue.