Problem/Motivation

Theme settings handling changed in #3203078: Refactor theme setting handling

Proposed resolution

Use the 'new' mechanism.

Issue fork gin_login-3258366

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

volkerk created an issue. See original summary.

saschaeggi made their first commit to this issue’s fork.

saschaeggi opened merge request !7

saschaeggi’s picture

saschaeggi
he/him
commented
Status: Active » Needs review
volkerk’s picture

volkerk commented
Status: Needs review » Needs work
saschaeggi’s picture

saschaeggi
he/him
commented
Status: Needs work » Needs review
volkerk’s picture

volkerk commented
Status: Needs review » Needs work

I think we should move the tooling upgrade / alignment to a separate issue.

Unfortunately the module does not work for me, logo, form and image are rendered one below the other?

saschaeggi’s picture

saschaeggi
he/him
commented

Strange for me it works perfectly fine with either latest Gin 3.x-dev (with current settings) and with the #3258015: Use default logo instead own icon (for new settings)
Did you clear the cache?

saschaeggi’s picture

saschaeggi
he/him
commented
Status: Needs work » Needs review
dieterholvoet’s picture

dieterholvoet commented
Status: Needs review » Reviewed & tested by the community

Works well! Tested in combination with #3258015: Use default logo instead own icon. Didn't review all code/config changes, but the output is right.

  • saschaeggi committed a0c75f2 on 8.x-1.x 
    Issue #3258366: Gin theme settings handling
saschaeggi’s picture

saschaeggi
he/him
commented
Status: Reviewed & tested by the community » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.