Problem/Motivation

Since composer/composer 2.0.0 the CLI flag --no-suggest is deprecated. (See https://github.com/composer/composer/blob/main/UPGRADE-2.0.md)

Currently this flag is used in the "drupal-phpunit-upgrade" script in the root composer.json.

Steps to reproduce

- Run the drupal-phpunit-upgrade script from the root composer.json
- React with horror to the message 'You are using the deprecated option "--no-suggest". It has no effect and will break in Composer 3.'

Proposed resolution

Remove the deprecated flag --no-suggest from "@composer require phpspec/prophecy-phpunit:^2 --no-progress --no-suggest"

Remaining tasks

- MR
- Review
- Commit
- Rejoice

Issue fork drupal-3258276

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Spokje created an issue. See original summary.

Spokje’s picture

Assigned: Spokje » Unassigned
Status: Active » Needs review
mondrake’s picture

Status: Needs review » Reviewed & tested by the community
alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed 5988bdf8d6e to 10.0.x and 613a875a9e1 to 9.4.x. Thanks!

In Drupal 10 we can remove the @composer require phpspec/prophecy-phpunit:^2 --no-progress it is a real dev dependency already.

  • alexpott committed 5988bdf on 10.0.x
    Issue #3258276 by Spokje: Remove deprecated flag --no-suggest from...

  • alexpott committed 613a875 on 9.4.x
    Issue #3258276 by Spokje: Remove deprecated flag --no-suggest from...

Spokje’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.