Problem/Motivation

Currently we don't style the video element, so it can be that if the video has a big width and height, that it will render beyond it's parent element.

Steps to reproduce

1. Enable social_embed
2. Upload a local video file and copy its URL
3. Create a new basic page and click the 'Media' button in CKEditor
4. Paste and embed the local video that you uploaded in the previous step.
5. See that the video is rendered beyond its parent width.

Proposed resolution

Setting the video element width to 100% should resolve all issues.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork socialbase-3257739

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

nkoporec created an issue. See original summary.

nkoporec opened merge request !85

nkoporec’s picture

nkoporec
Primary language English
Location Slovenia
CreditAttribution: nkoporec as a volunteer commented
Status: Active » Needs review
nachosalvador’s picture

nachosalvador CreditAttribution: nachosalvador at Open Social commented
Status: Needs review » Reviewed & tested by the community

Looks good to me

Agami4 credited tbsiqueira.

Agamich’s picture

Agamich CreditAttribution: Agamich as a volunteer and at Lemberg Solutions, Open Social, Drupal Ukraine Community for Open Social commented
Status: Reviewed & tested by the community » Fixed

The changes were merged into 2.1.x branch.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.