Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
I know PHP 7.3 is unsupported, but this module should either declare a minimum version requirement or fix it to work on 7.3 (7.3 is supported by d9)
Steps to reproduce
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
Issue fork monolog-3256472
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3256472-
changes, plain diff MR !2 - 3256472-syntax-error-on changes, plain diff MR !1
2 hidden branches
Comments
Comment #3
eiriksmComment #4
eiriksmTrying to trigger tests to prove the error 🤓
Comment #9
eiriksmGah, wanted to be clever here and manage to do this on my phone. So my bug report analysis is also based on using my phone but I don't think typed properties are allowed in 7.3. IE protected array $channels should be protected $channels
No idea why the tests are not starting though?
Comment #10
eiriksmComment #11
eiriksmLast try to start tests
Comment #12
eiriksmSeems the branch is not configured to test on issues. So either enable that, or start at 7.3 test on the 2.x branch manually should reveal the "bug"
Comment #13
lussolucaHi,
at this point I think I prefer to set 7.4 as the minimum PHP version supported.
Core supports 7.3 but is not recommended.
Comment #14
eiriksmOk, no worries. Then this should be reflected in composer.json so it's not possible by mistake. Updated PR for this
Comment #15
lussolucaThis way it works only on php greater than 7.4 but not on php 8
Comment #16
lussolucaComment #18
lussolucaI've resolved with
"php": "^7.4|^8",Comment #19
eiriksmAh geez you are totally right. Sorry about that. I guess it's incredible that I can open an issue and suggest a fix, all on my phone. At the same time, code quality...
Anyway, thanks for the quick fix!