1. The new library versions arrived. Let's update them inside the ludwig.json file before 8.x-1.10 is released.

2. A new "Drupal Core major version" optional compatibility argument is added to Ludwig 8.x-1.10 and new 2.0.x branch as well.

The Address module can take advantage of it and instruct Ludwig to load "doctrine/collections" library in Drupal 9 and Drupal 10 projects only and skip it in Drupal 8 projects (since the "doctrine/collections" library is part of D8 Core).

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

devad created an issue. See original summary.

devad’s picture

devad’s picture

Issue summary: View changes

The patch is ok (the branch tests are failing with D9).

devad’s picture

Status: Active » Needs work

Mistake. Ignore this.

devad’s picture

Status: Needs work » Needs review
jsacksick’s picture

@devad: Is the patch ready to commit as is? I'm confused by the fact that you hide it?

bojanz’s picture


+ "doctrine/collections d9 d10": {

No need for this rename now that we're dropping D8 support in Address.

devad’s picture

Re: #7. Sure. If d8 support is dropped this one-line-change is obsolete.

Here is a new patch which contains the library versions update only.

  • jsacksick committed 268c6df on 8.x-1.x authored by devad
    Issue #3256140 by devad, bojanz: Ludwig integration update.
    
jsacksick’s picture

Status: Needs review » Fixed

Committed, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.