Remove the WebformAssertLegacyTrait

Problem/Motivation

In the very challenging move from SimpleTest to PHPUnit, we create a WebformAssertLegacyTrait which did not deprecate commonly used assertions.

Proposed resolution

In preparation for Drupal 10, we need to remove the WebformAssertLegacyTrait.

Remaining tasks

Notes

• We can use PHPStorm to find method usage.
• If this is done correctly, we should be able to replace WebformAssertLegacyTrait with AssertLegacyTrait, so that the methods will be deprecated.
• Tests are allow to change but people maybe extending WebformBrowserTestBase and relying on the WebformAssertLegacyTrait.
• Use the change record for suggestions and replacement patterns

Preparation

• Standardize how $this->assertSession() is used.

Steps to remove WebformAssertLegacyTrait

• Remove unused methods for tests.
• Renamed simple methods (::assertEqual => assertEquals)
• Search replace more complese methods ($this->assertSomething() => $this->assertSession()->something())
• Document refactoring for critical methods (::drupalPostForm)

User interface changes

N/A

API changes

Deprecated assertions will now be flagged as deprecated.

Data model changes

N/A