Problem/Motivation

Steps to reproduce

The CKEditor5 modules has an integration test for QuickEdit, but the module is slated to be removed from core and moved to contrib.

Proposed resolution

Move these test (or the appropriate test cases from it) into QuickEdit's test namespace to facilitate the core removal.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3252214

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Spokje created an issue. See original summary.

Spokje opened merge request !1468

Spokje’s picture

Spokje
Primary language Dutch
CreditAttribution: Spokje commented
Assigned: Spokje » Unassigned
Status: Needs work » Needs review
longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Status: Needs review » Reviewed & tested by the community

The changes here are exactly what's needed and nothing more; I like how the diff only highlights 3 letters because "ckedit" is common to both module names.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Version: 9.4.x-dev » 9.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed f94b1247b8 to 10.0.x and 51f7c3feb1 to 9.4.x and dbe6299108 to 9.3.x. Thanks!

Backported to 9.3.x because this is test only.

  • alexpott committed f94b124 on 10.0.x 
    Issue #3252214 by Spokje: Move tests for integrations between QuickEdit...

  • alexpott committed 51f7c3f on 9.4.x 
    Issue #3252214 by Spokje: Move tests for integrations between QuickEdit...

  • alexpott committed dbe6299 on 9.3.x 
    Issue #3252214 by Spokje: Move tests for integrations between QuickEdit...

Spokje closed merge request !1468

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Kristen Pol’s picture

Kristen Pol
she/her
Primary language English
Location Santa Cruz, CA, USA
CreditAttribution: Kristen Pol at Itty Bitty Byte for Salsa Digital commented
Issue tags: -Drupal10 +Drupal 10

Fixing tag.