Problem/Motivation

Now that we are working on #3245770: Create a service to composer install via package_manager from Automatic Updates it is important that the validators don't try to validate Automatic Updates logic when Project Browser or another modules are using package_manager

Proposed resolution

In the classes in `src/Validator` and `src/Event` and probably anywhere we are listening to StageEvent subclass events outside of package_manager we should check to see if the stage is an instance of \Drupal\automatic_updates\Updater

For instance we could do this

if (!$event->getStage() instanceof Updater) {
   return;
}

Remaining tasks

Do it

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tedbow created an issue. See original summary.

tedbow’s picture

Issue summary: View changes

phenaproxima made their first commit to this issue’s fork.

phenaproxima’s picture

Status: Active » Needs review
tedbow’s picture

Status: Needs review » Reviewed & tested by the community

Looks good

phenaproxima’s picture

Title: Ensure that all Automatic Update StageEvent listeners only apply to Automatic Update uses » Ensure that all Automatic Updates event subscribers only apply to Automatic Updates uses
Status: Reviewed & tested by the community » Needs review

  • phenaproxima committed 08a14db on 8.x-2.x
    Issue #3249517 by phenaproxima: Ensure that all Automatic Updates event...
phenaproxima’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.