Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Here my project based on the version 8.x-2.x-dev:
github.com/Idas86/OwlCarousel2-for-Drupal8
Issue fork owlcarousel-3249236
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
compare
Comments
Comment #6
ShaxA CreditAttribution: ShaxA commentedGood work, when can we expect this to be merged!
Comment #7
ipwa CreditAttribution: ipwa at manifesto commentedThis looks amazing, thank you!
Going to give it a test, looking forward to approving the merge request!
Comment #8
ipwa CreditAttribution: ipwa at manifesto commentedHi Danielle, thanks so much for your amazing contribution!
I added some comments to the merge request, it would be good to get those issue fixed.
The indentation used on the changes uses a tab, this does not follow Drupal coding standards: https://www.drupal.org/docs/develop/standards/coding-standards#indenting
I am happy to open a new ticket for the code standard issues and also to implement the settings summary.
There is a functionality issue we need to fix before merging this. When ever I edit the settings in the views format settings they do get saved and the settings are applied. However when using as a field formatter the only settings that get saved are image style and link image to. Any of the other settings don't get changed and the only way I could change them was in code. We need to fix this.
Comment #9
chakkche CreditAttribution: chakkche as a volunteer and at QED42 commentedI will work on this.
Comment #10
chakkche CreditAttribution: chakkche as a volunteer and at QED42 commentedFixed all coding standards.
Comment #11
ipwa CreditAttribution: ipwa at manifesto commentedGreat work Chennakesavulu!
Did you get around to fixing the functionality issue in the field formatter too btw?
Will review and test this a little later.
Comment #12
chakkche CreditAttribution: chakkche as a volunteer and at QED42 commentedThanks @ipwa,
yes in my latest commit fixed the field formatter settings save issue too.
Comment #13
ipwa CreditAttribution: ipwa at manifesto commentedWhat an absolute legend!
Will review later, thanks so much!
Comment #15
ipwa CreditAttribution: ipwa at manifesto commentedAdding credit to other contributor that helped me review this.
Comment #17
ipwa CreditAttribution: ipwa at manifesto commentedSince @chakkche commits where not in the merge request branch when I checked it out locally I committed the changes instead of merging the merge request.
Comment #18
ipwa CreditAttribution: ipwa at manifesto commentedThanks so much @Idas and @chakkche for you valuable contribution. I really appreciate it and I'm sure the community really does too! Great work! w00t w00t!
@chakkche I added you to the credits section in the readme file because I consider your contribution significant too.
Hopefully both of you can give me a hand in the issue queue in the future, looking forward to any future merge requests!
Comment #20
chakkche CreditAttribution: chakkche as a volunteer and at QED42 commented@ipwa sure looking forward on that.
Comment #22
chakkche CreditAttribution: chakkche as a volunteer and at QED42 commentedComment #23
ipwa CreditAttribution: ipwa at manifesto commentedDon't: Change the status of an issue from "Fixed" to "Closed (fixed)". An issue with the status "Fixed" will be automatically closed as fixed and removed from the list of open issues after 14 days. It should remain open for 14 days after being "Fixed" to cater for regressions and other unintended consequences of the fix.
From: https://www.drupal.org/docs/develop/issues/issue-procedures-and-etiquett...