[PHP 8.1] Implicit conversion from float to int loses precision [#3248752]

Problem/Motivation

exception: [Deprecated function] Line 569 of modules/simpletest/tests/system_test.module:
Implicit conversion from float 7.5 to int loses precision

exception: [Deprecated function] Line 1998 of includes/common.inc:
Implicit conversion from float 2.3996500000000003 to int loses precision

exception: [Deprecated function] Line 755 of modules/color/color.module:
Implicit conversion from float 112.99284000000004 to int loses precision

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Comment	File	Size	Author
#12	3248752-12.patch	3.2 KB	mcdruid
#12	7.x: PHP 7.3 & MySQL 5.7 2,103 pass
#12	interdiff-3248752-10-12.txt	639 bytes	mcdruid
#10	3248752-10.patch	2.5 KB	mcdruid
#10	7.x: PHP 7.3 & MySQL 5.7 2,103 pass
#10	interdiff-3248752-9-10.txt	663 bytes	mcdruid
#9	3248752-9.patch	1.88 KB	mcdruid
#9	7.x: PHP 7.3 & MySQL 5.7 2,103 pass
#9	interdiff-3248752-8-9.txt	456 bytes	mcdruid
#8	3248752-8.patch	1.88 KB	mcdruid
#8	7.x: PHP 7.3 & MySQL 5.7 run-tests.sh exception
#8	interdiff-3248752-6-8.txt	913 bytes	mcdruid
#6	3248752-6.patch	1.88 KB	mcdruid
#6	7.x: PHP 7.3 & MySQL 5.7 run-tests.sh exception
#3	3248752-3.patch	839 bytes	mcdruid
#3	7.x: PHP 7.3 & MySQL 5.7 2,103 pass
#2	3248752-2.patch	835 bytes	mcdruid
#2	7.x: PHP 7.3 & MySQL 5.7 2,103 pass

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

10 November 2021 at 17:14

mcdruid created an issue. See original summary.

Comment #2

mcdruid

🇬🇧🇪🇺

CreditAttribution: mcdruid at Acquia commented 10 November 2021 at 17:17

Status:

Active

» Needs review

File	Size
3248752-2.patch	835 bytes
7.x: PHP 7.3 & MySQL 5.7 2,103 pass

Comment #3

mcdruid

🇬🇧🇪🇺

CreditAttribution: mcdruid at Acquia commented 10 November 2021 at 17:53

File	Size
3248752-3.patch	839 bytes
7.x: PHP 7.3 & MySQL 5.7 2,103 pass

Comment #4

mcdruid

🇬🇧🇪🇺

CreditAttribution: mcdruid at Acquia commented 10 November 2021 at 18:01

Issue summary:

View changes

Comment #5

mcdruid

🇬🇧🇪🇺

CreditAttribution: mcdruid at Acquia commented 10 November 2021 at 18:19

Issue summary:

View changes

Comment #6

mcdruid

🇬🇧🇪🇺

CreditAttribution: mcdruid at Acquia commented 10 November 2021 at 18:24

File	Size
3248752-6.patch	1.88 KB
7.x: PHP 7.3 & MySQL 5.7 run-tests.sh exception

2 files were hidden/shown/deleted

File	Size
3248752-2.patch	835 bytes
7.x: PHP 7.3 & MySQL 5.7 2,103 pass
3248752-3.patch	839 bytes
7.x: PHP 7.3 & MySQL 5.7 2,103 pass

Comment #7

mcdruid

🇬🇧🇪🇺

CreditAttribution: mcdruid as a volunteer and at Acquia commented 10 November 2021 at 19:05

Looking at #3224299-19: [META] Make Drupal 7 core compatible with PHP 8.1 the change here:

-    $out |= (($v * ($normalize ? 255 : 1)) << (16 - $k * 8));
+    $out = (int) $out | (($v * ($normalize ? 255 : 1)) << (16 - $k * 8));

...has not fixed the error (/ deprecation warning).

My guess is that there's a problem with the precedence.

I'm also not certain that this is doing what it should be, although it has stopped the warnings:

-     $interval %= $value;
+     $interval = (int) $interval % $value;

Comment #8

mcdruid

🇬🇧🇪🇺

CreditAttribution: mcdruid as a volunteer and at Acquia commented 10 November 2021 at 19:18

File	Size
interdiff-3248752-6-8.txt	913 bytes
3248752-8.patch	1.88 KB
7.x: PHP 7.3 & MySQL 5.7 run-tests.sh exception

I think this is better for the color.module

Comment #9

mcdruid

🇬🇧🇪🇺

CreditAttribution: mcdruid as a volunteer and at Acquia commented 10 November 2021 at 19:49

File	Size
interdiff-3248752-8-9.txt	456 bytes
3248752-9.patch	1.88 KB
7.x: PHP 7.3 & MySQL 5.7 2,103 pass

Didn't mean to include the extra parens in common.inc

Comment #10

mcdruid

🇬🇧🇪🇺

CreditAttribution: mcdruid as a volunteer and at Acquia commented 10 November 2021 at 20:55

File	Size
interdiff-3248752-9-10.txt	663 bytes
3248752-10.patch	2.5 KB
7.x: PHP 7.3 & MySQL 5.7 2,103 pass

Need to ensure values passed to imagecolorallocate are int's.

Comment #11

mcdruid

🇬🇧🇪🇺

CreditAttribution: mcdruid as a volunteer and at Acquia commented 10 November 2021 at 20:55

exception: [Deprecated function] Line 209 of modules/system/image.gd.inc:
Implicit conversion from float -7.105427357601002E-15 to int loses precision

Comment #12

mcdruid

🇬🇧🇪🇺

CreditAttribution: mcdruid as a volunteer and at Acquia commented 10 November 2021 at 21:07

File	Size
interdiff-3248752-10-12.txt	639 bytes
3248752-12.patch	3.2 KB
7.x: PHP 7.3 & MySQL 5.7 2,103 pass

Comment #13

11 November 2021 at 21:32

mcdruid committed 248892a on 7.x

Issue #3248752 by mcdruid: [PHP 8.1] Implicit conversion from float to...

Comment #14

mcdruid

🇬🇧🇪🇺

CreditAttribution: mcdruid as a volunteer and at Acquia commented 11 November 2021 at 21:32

Status:

Needs review

» Fixed

7 files were hidden/shown/deleted

File	Size
3248752-6.patch	1.88 KB
7.x: PHP 7.3 & MySQL 5.7 run-tests.sh exception
interdiff-3248752-6-8.txt	913 bytes
3248752-8.patch	1.88 KB
7.x: PHP 7.3 & MySQL 5.7 run-tests.sh exception
interdiff-3248752-8-9.txt	456 bytes
3248752-9.patch	1.88 KB
7.x: PHP 7.3 & MySQL 5.7 2,103 pass
interdiff-3248752-9-10.txt	663 bytes
3248752-10.patch	2.5 KB
7.x: PHP 7.3 & MySQL 5.7 2,103 pass

Comment #15

demeritcowboy CreditAttribution: demeritcowboy commented 19 November 2021 at 21:30

Hi,
I have added an issue and merge request https://git.drupalcode.org/project/drupal/-/merge_requests/1430 since part of the change to the color module here causes a problem with garland when not using blue lagoon.