Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
After #3231327: Plugin definition DX: validate ckeditor5.drupal.elements items and #3228505: Plugin definition DX: automatically check for plugin definitions whether their ::getDefaultSettings() matches the config schema, this still remains.
This would also help address #3246246: CKEditor 5 plugins needing more complex conditions.
Add validation ensuring that the values in CKEditor 5 plugin definition's drupal.conditions key are supported.
Steps to reproduce
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
| Comment | File | Size | Author |
|---|---|---|---|
| #12 | 3248188-12.patch | 8.25 KB | bnjmnm |
| |||
Issue fork drupal-3248188
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Issue fork ckeditor5-3248188
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3248188-plugin-def-validate-conditions
changes, plain diff MR !157
1 hidden branch
Comments
Comment #3
Wim LeersComment #4
Wim LeersComment #5
Wim LeersComment #6
bnjmnmThis is a good addition. The CKEditor 5 learning curve is going to be rough for most contributors, so anywhere we can catch clearly-incorrect config and provide useful guidance is great. It appears the test coverage accounts for all scenarios too.
I had some phrasing suggestions but other than that it's something I'd RTBC.
Comment #7
Wim LeersComment #10
Wim LeersAddressed all of @bnjmnm's feedback in https://git.drupalcode.org/issue/ckeditor5-3248188/-/tree/3248188-plugin..., then ported it verbatim to https://git.drupalcode.org/issue/drupal-3248188/-/tree/3248188-plugin-de..., followed by me closing the first one.
Comment #12
bnjmnmPatch to simplify this being added to multiple versions.
Comment #13
Wim Leers🙏
Comment #14
bnjmnmAll my feedback was addressed a while back apparently! This is a useful additional layer of validation that does a good job explaining exactly what is needed to address a given error.
Comment #15
Wim Leers🥳
Comment #19
lauriiiCommitted e264ec6 and pushed to 10.0.x. Also cherry-picked to 9.4.x and 9.3.x because CKEditor 5 is experimental. Thanks!