"Place a colon after the label" not working on grouping field label on views

Thanks for reporting

@FiNeX Could you provide me more information about the problem? I created a scenario but I'm not being able to understand when this happens, this was what I did:

• Created a view
• Added some fields like : Title, Topics and Date
• I created some contents and added the same topics for two of them
• I clicked on edit at my view and after I clicked on FORMAT > Settings
• And I chose my "topics" field as Group Field Nr.1

I'm not sure if I follow the right steps...'Cause as I said I couldn't reproduce the problem you talked about. So if you could give me the steps it would help me a lot. thank you!!

Thank you for the steps, @FiNeX. I was able to reproduce so I'll be working working on this.

I unassigned me from the issue because I'm not being able to resolve it. I found the point of the code that I could remove the colon
( template_preprocess_views_view_unformatted(&variables)), and it stayed just it had to be, but I'm having some problems with find the property that tells me that the label colon it is not requested. Besides, I think the changes must be not only the template_preprocess_views_view_unformattedbut at all formats that includes the "place a colon" option. So, as I'm very stuck, I will unassigned me. Thanks.

This is handled in the StylePluginBase class and it does indeed not take this setting into consideration.

Here is a test and a fix for this.

I made a little view to test and it looks like the patch works.

1. Colons without patch:
2. "No-colons" without patch:
3. Colons with patch:
4. No-colons with patch

And the new test coverage looks good. It fails perfectly.

I thought that the changes below were out of scope, just some nearby cosmetic changes. Then I realized that we need to keep $expected from being altered because we use it in the new coverage further down.

+++ b/core/modules/views/tests/src/Kernel/Plugin/StyleTest.php
@@ -227,15 +227,49 @@ protected function doTestGrouping($stripped = FALSE) {
-
+    $no_label_expected = $expected;
     // Remove labels from expected results.
-    foreach ($expected as $job => $data) {
-      unset($expected[$job]);
+    foreach ($no_label_expected as $job => $data) {
+      unset($no_label_expected[$job]);
       $job = str_replace('Job: ', '', $job);
       $data['group'] = $job;
-      $expected[$job] = $data;
+      $no_label_expected[$job] = $data;
     }
-    $this->assertEquals($expected, $sets_new_rendered);
+    $this->assertEquals($no_label_expected, $sets_new_rendered);

But now this all makes sense. RTBC. Cheers!

Looked at the test to see if it was worth trying to redefine $expected into multiple arrays in the first place, but that'd be tonnes of boilerplate so the bits of manipulation seems OK.

Committed/pushed to 10.0.x and cherry-picked to 9.4.x and 9.3.x, thanks!